Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <54b3fb4d5a58d123826a7f0c8442379dc071dfcc.camel@redhat.com>
Subject: Re: =?UTF-8?Q?=E5=9B=9E=E5=A4=8D=3A?= [PATCH net v1] ath6kl:Fix
 error checking for debugfs_create_dir()
From:   Paolo Abeni <pabeni@redhat.com>
To:     =?UTF-8?Q?=E7=8E=8B=E6=98=8E-=E8=BD=AF=E4=BB=B6=E5=BA=95=E5=B1=82?=
         =?UTF-8?Q?=E6=8A=80=E6=9C=AF=E9=83=A8?= <machel@vivo.com>
Cc:     Kalle Valo <kvalo@kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "opensource.kernel" <opensource.kernel@vivo.com>
Date:   Thu, 13 Jul 2023 11:43:44 +0200
In-Reply-To: <SG2PR06MB374387D043556FE8AEAA6ED9BD37A@SG2PR06MB3743.apcprd06.prod.outlook.com>
References: <20230713040518.13734-1-machel@vivo.com>
         <a9dc336793322d3525280e4f30b2acbd0c88bbf8.camel@redhat.com>
         <SG2PR06MB374387D043556FE8AEAA6ED9BD37A@SG2PR06MB3743.apcprd06.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-07-13 at 09:31 +0000, =E7=8E=8B=E6=98=8E-=E8=BD=AF=E4=BB=B6=E5=
=BA=95=E5=B1=82=E6=8A=80=E6=9C=AF=E9=83=A8 wrote:
> Thank you for pointing out, I will pay attention to it in the future.
> In addition, do I need to modify this patch and submit it again?

Yes, a v2 is needed.=20

There are a few patches on this same topic, and I read only now what
Simon noted:

https://lore.kernel.org/linux-wireless/ZG8YY%2Fr8BLCzw93q@corigine.com/

so, the current code is likely not really buggy, and a possible cleanup
patch (such patch would _not_ be a fix) could simply remove the check
altogether.

Cheers,

Paolo