Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <486cb426-737e-fa57-20da-344fc44bb4de@candelatech.com>
Date:   Fri, 14 Jul 2023 09:00:20 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 1/3] wifi: mt76: mt7915: move mib_stats structure in
 mt76.h
Content-Language: en-US
To:     Lorenzo Bianconi <lorenzo@kernel.org>, nbd@nbd.name
Cc:     lorenzo.bianconi@redhat.com, linux-wireless@vger.kernel.org
References: <cover.1683930235.git.lorenzo@kernel.org>
 <d7f29306df3495e183304825cd3159bf1ccb1d87.1683930235.git.lorenzo@kernel.org>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
In-Reply-To: <d7f29306df3495e183304825cd3159bf1ccb1d87.1683930235.git.lorenzo@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/12/23 15:29, Lorenzo Bianconi wrote:
> mib_stats structure is shared by mostly all chipsets. Move it to shared
> code.

In case this thing hasn't been pushed upstream yet, then a suggestion:

Create a struct mt76_mib_stats_common class that has the common counters,
and then per-driver can have that struct as first member of its mib stats.

I have added a lot of per-driver stats that never made it upstream
and are not fully shared across different drivers.

Thanks,
Ben

> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>   drivers/net/wireless/mediatek/mt76/mt76.h     | 63 +++++++++++++++++++
>   .../wireless/mediatek/mt76/mt7915/debugfs.c   |  4 +-
>   .../net/wireless/mediatek/mt76/mt7915/mac.c   |  2 +-
>   .../net/wireless/mediatek/mt76/mt7915/main.c  |  4 +-
>   .../wireless/mediatek/mt76/mt7915/mt7915.h    | 63 +------------------
>   5 files changed, 69 insertions(+), 67 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wireless/mediatek/mt76/mt76.h
> index 75b5c2c56a92..45bf1022a051 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt76.h
> @@ -857,6 +857,69 @@ struct mt76_dev {
>   	};
>   };
>   
> +/* per-phy stats.  */
> +struct mt76_mib_stats {
> +	u32 ack_fail_cnt;

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com