Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <tencent_283F851E543C098B9BC8DAA32D79B00A0F07@qq.com>
From:   Zhang Shurong <zhang_shurong@foxmail.com>
To:     linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Jakub Kicinski <kuba@kernel.org>,
        Kalle Valo <kvalo@kernel.org>,
        Ping-Ke Shih <pkshih@realtek.com>,
        Markus Elfring <Markus.Elfring@web.de>
Cc:     LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] wifi: rtw89: debug: fix error code in
 rtw89_debug_priv_btc_manual_set
Date:   Sat, 15 Jul 2023 17:56:10 +0800
In-Reply-To: <a97b0b0c-8141-5391-727a-aa29fedc016b@web.de>
References: <tencent_7C09B91B925AF62D7CB0280F028563540807@qq.com>
 <a97b0b0c-8141-5391-727a-aa29fedc016b@web.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

=E5=9C=A8 2023=E5=B9=B47=E6=9C=8815=E6=97=A5=E6=98=9F=E6=9C=9F=E5=85=AD CST=
 =E4=B8=8B=E5=8D=885:22:08=EF=BC=8CMarkus Elfring =E5=86=99=E9=81=93=EF=BC=
=9A
> > If there is a failure during kstrtobool_from_user()
> > rtw89_debug_priv_btc_manual_set should return negative error code
> > instead of returning the count driectly.
> >=20
> > Fix this bug by returning the correct error code.
>=20
> How do you think about to use an other wording approach
> (like the following) for an improved change description?
>=20
>=20
>   Return an error code instead of a count after a failed call
>   of the function =E2=80=9Ckstrtobool_from_user=E2=80=9D.
>   Omit the label =E2=80=9Cout=E2=80=9D with this source code correction.
>=20
>=20
> Regards,
> Markus
Thanks for your kindness reply and advice and I will change my description
in the next version.

Regards,
Shurong