Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 15 Jul 2023 13:54:30 +0200
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Ben Greear <greearb@candelatech.com>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>, nbd@nbd.name,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] wifi: mt76: mt7915: move mib_stats structure in
 mt76.h
Message-ID: <ZLKI9tiNytMl8Vlo@lore-desk>
References: <cover.1683930235.git.lorenzo@kernel.org>
 <d7f29306df3495e183304825cd3159bf1ccb1d87.1683930235.git.lorenzo@kernel.org>
 <486cb426-737e-fa57-20da-344fc44bb4de@candelatech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4D+/XRYv8Rax2OeT"
Content-Disposition: inline
In-Reply-To: <486cb426-737e-fa57-20da-344fc44bb4de@candelatech.com>
Precedence: bulk


--4D+/XRYv8Rax2OeT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On 5/12/23 15:29, Lorenzo Bianconi wrote:
> > mib_stats structure is shared by mostly all chipsets. Move it to shared
> > code.
>=20
> In case this thing hasn't been pushed upstream yet, then a suggestion:
>=20
> Create a struct mt76_mib_stats_common class that has the common counters,
> and then per-driver can have that struct as first member of its mib stats.
>=20
> I have added a lot of per-driver stats that never made it upstream
> and are not fully shared across different drivers.

I would say mt76_mib_stats is quite a general name. I think we can do somot=
hing
like (if it is really necessary):

struct mt7915_mib_stats {
	struct mt76_mib_stats mt76;
	...
};

Regards,
Lorenzo

>=20
> Thanks,
> Ben
>=20
> >=20
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >   drivers/net/wireless/mediatek/mt76/mt76.h     | 63 +++++++++++++++++++
> >   .../wireless/mediatek/mt76/mt7915/debugfs.c   |  4 +-
> >   .../net/wireless/mediatek/mt76/mt7915/mac.c   |  2 +-
> >   .../net/wireless/mediatek/mt76/mt7915/main.c  |  4 +-
> >   .../wireless/mediatek/mt76/mt7915/mt7915.h    | 63 +------------------
> >   5 files changed, 69 insertions(+), 67 deletions(-)
> >=20
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wi=
reless/mediatek/mt76/mt76.h
> > index 75b5c2c56a92..45bf1022a051 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76.h
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76.h
> > @@ -857,6 +857,69 @@ struct mt76_dev {
> >   	};
> >   };
> > +/* per-phy stats.  */
> > +struct mt76_mib_stats {
> > +	u32 ack_fail_cnt;
>=20
> --=20
> Ben Greear <greearb@candelatech.com>
> Candela Technologies Inc  http://www.candelatech.com
>=20
>=20

--4D+/XRYv8Rax2OeT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZLKI9gAKCRA6cBh0uS2t
rDI4AQDSjKDXZ6AbzTHfPrmpnCFvJvf9oRDR1fcGOCwjMv3HtwEA7bDBKTUD0ken
m79xrORxMP5kAwyEQglWOGvX3MFybgY=
=D/hV
-----END PGP SIGNATURE-----

--4D+/XRYv8Rax2OeT--