Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 1/3] wifi: mt76: mt7915: move mib_stats structure in
 mt76.h
To:     Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>, nbd@nbd.name,
        linux-wireless@vger.kernel.org
References: <cover.1683930235.git.lorenzo@kernel.org>
 <d7f29306df3495e183304825cd3159bf1ccb1d87.1683930235.git.lorenzo@kernel.org>
 <486cb426-737e-fa57-20da-344fc44bb4de@candelatech.com>
 <ZLKI9tiNytMl8Vlo@lore-desk>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <a168df1e-573a-43ba-b466-b7e5784dc2ff@candelatech.com>
Date:   Sat, 15 Jul 2023 17:00:28 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <ZLKI9tiNytMl8Vlo@lore-desk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-MW
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/15/23 4:54 AM, Lorenzo Bianconi wrote:
>> On 5/12/23 15:29, Lorenzo Bianconi wrote:
>>> mib_stats structure is shared by mostly all chipsets. Move it to shared
>>> code.
>>
>> In case this thing hasn't been pushed upstream yet, then a suggestion:
>>
>> Create a struct mt76_mib_stats_common class that has the common counters,
>> and then per-driver can have that struct as first member of its mib stats.
>>
>> I have added a lot of per-driver stats that never made it upstream
>> and are not fully shared across different drivers.
> 
> I would say mt76_mib_stats is quite a general name. I think we can do somothing
> like (if it is really necessary):
> 
> struct mt7915_mib_stats {
> 	struct mt76_mib_stats mt76;
> 	...
> };

Maybe:

struct mt7915_mib_stats {
	struct mt76_mib_stats common;
	...
};

I also noticed that Ryder added a few of my patches that extended the
stats, so I think there are probably a lot of stats in that struct
that are not set on the 7921 driver and probably older drivers too.

To me, unset stats are confusing, so I'd prefer to put stats that are mostly
common in a common struct, and have per-driver stats just found in the driver
itself.

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com