Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2300d056-26ad-d0ad-4527-f395cab06729@yandex.ru>
Date:   Mon, 17 Jul 2023 18:30:33 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Content-Language: en-US
To:     Wright Feng <wright.feng@cypress.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Chi-hsien Lin <chi-hsien.lin@cypress.com>
From:   Dmitry Antipov <dmantipov@yandex.ru>
Subject: On brcmfmac console reading timer
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

In dcb485dfc83b ("brcmfmac: add a timer to read console periodically in PCIE bus"), what
time units are assumed to manage the 'console_interval' of 'struct brcmf_pciedev_info'?
If the former is in jiffies, then comparing it with 'MAX_CONSOLE_INTERVAL' (which is in
seconds) in brcmf_pcie_console_interval_set() doesn't work in the way you might expect;
if it is in seconds, then the same applies to an attempts to reschedule timer with
'mod_timer(&devinfo->timer, jiffies + devinfo->console_interval)' etc.

Dmitry