Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e3977212-41f3-f4c3-faf9-febf0b0667d9@quicinc.com>
Date:   Mon, 17 Jul 2023 09:03:40 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v3] wifi: rtw89: debug: fix error code in
Content-Language: en-US
To:     Zhang Shurong <zhang_shurong@foxmail.com>, <pkshih@realtek.com>,
        <Markus.Elfring@web.de>, <kuba@kernel.org>
CC:     <kvalo@kernel.org>, <linux-wireless@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <tencent_1BEE491CDD88D78E6D0583D57B7C2844A00A@qq.com>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <tencent_1BEE491CDD88D78E6D0583D57B7C2844A00A@qq.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/15/2023 5:51 AM, Zhang Shurong wrote:
> If there is a failure during kstrtobool_from_user()
> rtw89_debug_priv_btc_manual_set should return negative error code
> instead of returning the count driectly.

nit: s/driectly/directly/

> 
> Fix this bug with the following changes:
> - Return an error code instead of a count after a failed call
> of the function "kstrtobool_from_user".
> - Omit the label "out" with this source code correction.
> 
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
> ---
> Changes in v2:
> - Corrected the format of this patch
> - Used variable ret instead of goto out
> Changes in v3:
> - Improved change description
> 
>   drivers/net/wireless/realtek/rtw89/debug.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/debug.c b/drivers/net/wireless/realtek/rtw89/debug.c
> index a4bbac916e22..ce5a9ac08145 100644
> --- a/drivers/net/wireless/realtek/rtw89/debug.c
> +++ b/drivers/net/wireless/realtek/rtw89/debug.c
> @@ -3193,12 +3193,14 @@ static ssize_t rtw89_debug_priv_btc_manual_set(struct file *filp,
>   	struct rtw89_dev *rtwdev = debugfs_priv->rtwdev;
>   	struct rtw89_btc *btc = &rtwdev->btc;
>   	bool btc_manual;
> +	int ret;
>   
> -	if (kstrtobool_from_user(user_buf, count, &btc_manual))
> -		goto out;
> +	ret = kstrtobool_from_user(user_buf, count, &btc_manual);
> +	if (ret)
> +		return ret;
>   
>   	btc->ctrl.manual = btc_manual;
> -out:
> +
>   	return count;
>   }
>