Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp6908938rwp; Tue, 18 Jul 2023 07:29:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlHJF5yfpUCghEkvgicdwZ6kIzZzTfwRJwEIBPzkWsaH9amIXy/dfNYynFchEwcnm0Bh/pZQ X-Received: by 2002:a05:6512:686:b0:4fd:c771:ed86 with SMTP id t6-20020a056512068600b004fdc771ed86mr3471315lfe.67.1689690583580; Tue, 18 Jul 2023 07:29:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689690583; cv=none; d=google.com; s=arc-20160816; b=tc6XjCvEiqNfxu2LXKSjm5sgNJEKnBFTiyiae+avcM8+ZWBHEQ1cMcP+9P7bQR6Qt9 phfIOwMa/Aad5i38WEivMLaQ+2ITB2EeyKaEkBMKdLhuiaxQBHrvpjxV9Y3uYzxzhVTi z3glD4R0FsWL6jK0y3uP8NFDgNXiAd24qjAjyoyqHnyr8w4W30wYlzCH7fZKLZGuId8s JhELywi4IQ538FxmHZPWwO9/LPve9cDrxplEsNkdbOo80Qqrn1rsoaIkN8RmHDu2VbaZ 0gH2VtfNQayOPRPwNnaE8XU82oQmYaEhdBuKCCBsHiGy3uCuuS2RVSIp7xIjYelJZ6qV PVgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=foGX3qPz8g1mE0AjGZ0RURTetuvRz0ZaIIFsjuTQ33o=; fh=MgPMIZvOMMpRAJ3r8XS9sc9LEuEFpjQuBvX6ASKJwvI=; b=IbYQI+VxCldpN/QRViNw1q1JlQBUd2eXftY61vamqYImjNBJKCWdI0+yLnP1wE6XdA zUDnzJzpIpnR58if80mbkg7zPuPGpVjF/ePolt9UnL4XosF78y5saoj+s61rDvKc/8XR ob5XisvGCrxOFbMUAKIYVzJXM/nPfgfubLeWmAUN+bq5nxalW9zfv2Pdl9NN7XY8a2kM XJkIi95g8JUObE4CTSq6oTBTwlUtIlNAX/yW+sYmzcCHBw8vKIvIQd6e2DR8LzvYfZnr aJWQ/XOsQvX6zd4kB22SMekdesFQiN2K04f59CEWPzIBgvldbcHM19RtDnleCWEHy7hJ 9MvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=JBWA+Dva; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y6-20020aa7d506000000b0051df8ee23f5si1275203edq.175.2023.07.18.07.29.23; Tue, 18 Jul 2023 07:29:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=JBWA+Dva; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232976AbjGRORG (ORCPT + 59 others); Tue, 18 Jul 2023 10:17:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232446AbjGRORE (ORCPT ); Tue, 18 Jul 2023 10:17:04 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6E58188; Tue, 18 Jul 2023 07:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=foGX3qPz8g1mE0AjGZ0RURTetuvRz0ZaIIFsjuTQ33o=; b=JBWA+Dva8h/kZCHzxx0beMUCVO DBM9NutUs8keY3cK4qSE6pjYwC5UbxQ9p8BI2hjbn36sLUsJjXa4y569DibqyziXWk0dXdIQ/ymwt OrHeqJt0QmXf5YAkADGAfUAJ3xrX0I1mXokQ96A+GrImP/aazfRTj/U6IF8GcT4CGHYo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qLlUl-001dCP-Ng; Tue, 18 Jul 2023 16:16:07 +0200 Date: Tue, 18 Jul 2023 16:16:07 +0200 From: Andrew Lunn To: "Quan, Evan" Cc: "rafael@kernel.org" , "lenb@kernel.org" , "Deucher, Alexander" , "Koenig, Christian" , "Pan, Xinhui" , "airlied@gmail.com" , "daniel@ffwll.ch" , "johannes@sipsolutions.net" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "Limonciello, Mario" , "mdaenzer@redhat.com" , "maarten.lankhorst@linux.intel.com" , "tzimmermann@suse.de" , "hdegoede@redhat.com" , "jingyuwang_vip@163.com" , "Lazar, Lijo" , "jim.cromie@gmail.com" , "bellosilicio@gmail.com" , "andrealmeid@igalia.com" , "trix@redhat.com" , "jsg@jsg.id.au" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH V6 1/9] drivers core: Add support for Wifi band RF mitigations Message-ID: <642e3f4d-976b-4ee1-8f63-844b9568462e@lunn.ch> References: <20230710083641.2132264-1-evan.quan@amd.com> <20230710083641.2132264-2-evan.quan@amd.com> <5439dd61-7b5f-4fc9-8ccd-f7df43a791dd@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > The wbrf_supported_producer and wbrf_supported_consumer APIs seem > unnecessary for the generic implementation. I'm happy with these, once the description is corrected. As i said in another comment, 'can' should be replaced with 'should'. The device itself knows if it can, only the core knows if it should, based on the policy of if actions need to be taken, and there are both providers and consumers registered with the core. Andrew