Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp7622351rwp; Tue, 18 Jul 2023 19:39:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlELc1fVWb46W4G9ZB+vHm8Wvb7cak0b568UuuVYnkMi2l+VQsdoBmK++8thI8Ne3NZWIHb3 X-Received: by 2002:a2e:9d8c:0:b0:2b9:44c5:ac15 with SMTP id c12-20020a2e9d8c000000b002b944c5ac15mr792843ljj.41.1689734361982; Tue, 18 Jul 2023 19:39:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689734361; cv=pass; d=google.com; s=arc-20160816; b=Qn/Zrp5A+HoivqpFj5YPHWySgPcKXCDbT8VLoDwpEtjnHJaNSYU4rqyjdzRf6sp1fI YA3uZMXfK5HBRgv0aVbTv6pHsg8l/jPjMJhI1ex5qC1/gWk59+UeHoP9cmpypW4/ScEh znbnpXk+/LA0gD+W32FUZMNwGSjtP1kQQxYlwkA55J1SEHJ/jK5RDQ+W43q8di0qjjcM 8gtu0Mo4Y7y68mPEHdl2Z+tKSavhaFc+uQfIZCI/ZQfR3M1vopy2VapujrvByW1UmvWW j4P1Gk29mQv96RaFI3xUDaF7uDVJ+qK2Aw/iEopWIL1LTVZfGJoDzKVTEmfKFIgct9te XRnA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :msip_labels:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=ZaVCpHOPaBUR/NZJWYFrraFTfmsRWHmM2UZewpxm+B4=; fh=NafiNVILA+PEOm46+8QrIquBvhlj9gw3Cf3PULxoDus=; b=dpS6b2ijARf30MXjLkEPmleBkKkIngReDo+LwoAZQ3L2R1awwkJxz8y+oJsukEBUv5 WCNnoY/qsRR/LTD9m74Hye/XFdHigkVZ52KKEU57yOaVW2FB3TZy9GbKLy+wLlSHKbUd BBdkHW/iFuEEsUQymCndc80cVYWhC8IM+t93dHZiZLlQm3ARAdROmasoqJrWhK8FJH37 vLnAlDwXoVDvygCVuh6lIxOghwvqDPkCzjESUQJaM83uC+Q60wt9d5wjeGu27nRdJZil +Vwndv9OCWgxyyn3iTcDqsYXeSYZyPmJnYMTTHx80xfegPCQzjpyl/ZMb+l9+oWijO8Y 1T9g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=tMTsyGfO; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pj22-20020a170906d79600b00992acf124b3si2050848ejb.926.2023.07.18.19.39.02; Tue, 18 Jul 2023 19:39:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=tMTsyGfO; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229761AbjGSC3r (ORCPT + 58 others); Tue, 18 Jul 2023 22:29:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229649AbjGSC3q (ORCPT ); Tue, 18 Jul 2023 22:29:46 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2040.outbound.protection.outlook.com [40.107.223.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F9331BC6; Tue, 18 Jul 2023 19:29:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vj540kJKu/n6d00Zh6M1dUET6i4U0cmP0GFMBkL6P3MQtU11SgtlzVxzadH1+zpfe3u5isoNhxFNAM69NMxF95wDl3gcqXNWvKnd2Yrlx/me9N0eZFuN37bYhG24LtaoKB0z2syKcWplgvD880NAvAwiy0NHw/tjX+oRKm8FGSSWaFoBAoOXzEgoWPrrsthqRNvjlwwt5csQGQGeP13TImN01JzJOzZhU0tMq+tevr2Hz3rWhAar7zTqgHx6+kbxRhgf70FGuqoV9OwKzepXJ0pYUQu5oh6384hAhkUAbbjYG3vv7R/DHMF6LxBnotcxVU1sb8n0BCOKDiIRtmHZqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZaVCpHOPaBUR/NZJWYFrraFTfmsRWHmM2UZewpxm+B4=; b=XGOVFCMQLmb3LgbdBRn517vxdmLUIdenjsZXN4O5UUo3lfH2zk1f5J/viAA/SMs152bfTmVMPfHf6cvWQvpISW95y3hojMxaTT074+iXyOlwVF53obPjKmmlcyhjGf34eWBYzStoBzo+ZVDh/rJnCWE1rVv1DS2fJTk4AV9v9qwHUoEupvYcg5/kWuBWHY1mj2opu8fDbMEW8pqkG5h8WfWdOmwQQFN67LFwnGE5f4ffT8eESBK88wopdAz3lPUdg4CZ+q3S605GsBDNA1YbbXeTBfM71VjYMiu+VnUopdsAFaI7ohqB89yRmd114JxhHM+WeE4RBbaE1S4kHlRy5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZaVCpHOPaBUR/NZJWYFrraFTfmsRWHmM2UZewpxm+B4=; b=tMTsyGfOkOXhQESCZp26L9Mp8eWRkYTo4ZNZocSHPUz6sW9YH5Rm6zS3WAEna7GjcX8nPf4i3rRvwklTw31ALRnO+kLx0EUmnujuMgU9HjTyTXcOdVlBJTTFNqOzGksaSBp3nTMX3ELaznERADJKqheYYk+6qp19J9aP+KBo750= Received: from DM6PR12MB2619.namprd12.prod.outlook.com (2603:10b6:5:45::18) by CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Wed, 19 Jul 2023 02:29:41 +0000 Received: from DM6PR12MB2619.namprd12.prod.outlook.com ([fe80::93dc:de92:88e7:b765]) by DM6PR12MB2619.namprd12.prod.outlook.com ([fe80::93dc:de92:88e7:b765%4]) with mapi id 15.20.6588.031; Wed, 19 Jul 2023 02:29:41 +0000 From: "Quan, Evan" To: Andrew Lunn CC: "rafael@kernel.org" , "lenb@kernel.org" , "Deucher, Alexander" , "Koenig, Christian" , "Pan, Xinhui" , "airlied@gmail.com" , "daniel@ffwll.ch" , "johannes@sipsolutions.net" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "Limonciello, Mario" , "mdaenzer@redhat.com" , "maarten.lankhorst@linux.intel.com" , "tzimmermann@suse.de" , "hdegoede@redhat.com" , "jingyuwang_vip@163.com" , "Lazar, Lijo" , "jim.cromie@gmail.com" , "bellosilicio@gmail.com" , "andrealmeid@igalia.com" , "trix@redhat.com" , "jsg@jsg.id.au" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" Subject: RE: [PATCH V6 1/9] drivers core: Add support for Wifi band RF mitigations Thread-Topic: [PATCH V6 1/9] drivers core: Add support for Wifi band RF mitigations Thread-Index: AQHZswnuaUrcGkEUvkO69ZFpbKmfV6+2xnYAgAiUksCAAEOtgIAAzFPg Date: Wed, 19 Jul 2023 02:29:40 +0000 Message-ID: References: <20230710083641.2132264-1-evan.quan@amd.com> <20230710083641.2132264-2-evan.quan@amd.com> <5439dd61-7b5f-4fc9-8ccd-f7df43a791dd@lunn.ch> <642e3f4d-976b-4ee1-8f63-844b9568462e@lunn.ch> In-Reply-To: <642e3f4d-976b-4ee1-8f63-844b9568462e@lunn.ch> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=0a4e7673-5735-4d66-9a58-992e97d36ed8;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-07-19T02:27:25Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB2619:EE_|CO6PR12MB5396:EE_ x-ms-office365-filtering-correlation-id: c8309da3-b302-43f2-322d-08db88000186 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f+9P7GH8uHLy2OSUISPGVeNaEQqGzFTDJ3l8QmNw7WibK7tFQun/5ntOCgYhFIjVACjos3AiwDjU3BYVySz4pRMHFGoMXBvJPGrlBPvc60PmAM3hyv/pV7R4A0Ga/AZ/SSRW1IZeOowiF3hyS7RzyB6EyvRsc6Q3l7T61SlBYdC/Sc4R+MiwZCJHVpymFomG7YOVb6hda5cyNuFlqVSIgbFqTe+EUZe3yVgC5EOSU+u/aQJZDY3l0HEM3gaT2ecPiC39Mg5xyZesoEPNcn+XmFimZxpwRGxWSwcdW2Pa1m12yAeHZgq+G6dk6iLd1bejCuDo2t66/1oRiMbWv5rxZDamu95LvCpVuBNqwhSlGB+WWNdFU18C4ebydf0cvZGr2dpfxRQ5XrVfZtmUTMx04v4aHy4B7NEJ4af3PXnbeKuJAOGbfSO98RH0ppzFLPe3OgLhSm6w4toetebmwlgJIEtsmeAvpLVfQDtC6ccx/VoWDqQH8nTQSsOC3r5kk7cFbaAcC3ypMuy6SQkdoXGuWERlOJ1zEuQtLaHSmOzn7O7agqqHs8xJ1WoqPpTdTOPzEFrUB7Ap7wsRv7Y+sKOUqqOKHvdzdaMF2WQcWovlKIR2kTvHYM3/MZw/KcD9WLNg x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2619.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(376002)(396003)(366004)(346002)(451199021)(55016003)(54906003)(478600001)(38070700005)(86362001)(186003)(26005)(33656002)(6506007)(53546011)(71200400001)(122000001)(83380400001)(38100700002)(9686003)(2906002)(7696005)(7416002)(8936002)(8676002)(52536014)(6916009)(41300700001)(64756008)(76116006)(66446008)(66476007)(66556008)(66946007)(5660300002)(316002)(4326008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VYbk73/l3kpVglm4+2oNneT0ERyB2weVQXH+SkIpMnB8T9wKFdFExIAzzwpM?= =?us-ascii?Q?K+xjJVUHSVo5Jt5eH3kkab93N8VDcpD6J1xK7tXfXJi+o3gxNuNcmmIHs9cg?= =?us-ascii?Q?YhHe7N1ewWuqHinss5vI5PiVUQ6F6rh0fyqv6ZNsxVfhLMZjpxQ+KLcgnUsI?= =?us-ascii?Q?B8YxO/HSdMs1vxGw3033M4oSkWZX9bWxk+25QPPnNTXaEpFz7zTCiH4YhuaM?= =?us-ascii?Q?UhNrMikX9IaYlxdJVX4sWCB+LvUfq7aUPmTViv0BR60jQQNZoMbRT/hFIS2W?= =?us-ascii?Q?vEzehbGLHGnt5AT1swtX2N7QklE8q7/FprjyRP95NnmBDaRzOtGlIyn29cvY?= =?us-ascii?Q?Sp4bJ1XimkADms4G45PHd8auhN2Lk/UIsUP4TBrDMJzG2Sp5qgNSoTwheKlO?= =?us-ascii?Q?rcdXCcQWekoD96YABC+i+qRx4HlsU+7lQtIyGZ3Pv0dePSUoTsORVxiMUWLe?= =?us-ascii?Q?vMmryrBwndoKEzyyUCCRPlnSTwUarzDLm6Z+fhfTIjFszkdHAepqOdcC+iU4?= =?us-ascii?Q?13oCXY85OE3GJYhu6TEAKxSym0m4o9PeUChdRW8yt9buLxWta3PB2449oBt6?= =?us-ascii?Q?BIhbNDpxMuO3i6NOafaAjWEKftHqJu0KHDGslRDuqI7OrLgqQYZ1iI89p4Df?= =?us-ascii?Q?W3qH2/dwukKaKR++QDTUEY1epM5sKb1Yf9vUi+0ZzWipJ8QkF68GjK6S4Ffm?= =?us-ascii?Q?C981bcVWzO4M5sFgYPoFHDN1SFHFJvBQJaQadHQdoCAmDFysoKR0AW19aXQ6?= =?us-ascii?Q?rWq0i43R+d6dnNNwznj5p+EZBUcR1wBDO/OGob8t9AyxMMuEj0N0SS0Nkv/R?= =?us-ascii?Q?YPcX+BXgfZY0t0RjitIzL7ExZUwamub9tZpdQnC2OIxhUjjDpMZv8GzEohsg?= =?us-ascii?Q?wDPHuypYjIiWxcVdj7b7xkAJG1iyHYKY09V7TwukbfK/eJjUGkP6rgp2T/13?= =?us-ascii?Q?R8TMS1TweAgkGvI0xHMUEuhIVUesurXJVLWzy+7Co7TSw8mjlftAXwXGWUAs?= =?us-ascii?Q?GsnVo9JEOw8P2UCuEd3HRbS1GjA6HfYo4uN2d/T0XjRZfxJhwMh5xMvcy5k1?= =?us-ascii?Q?+vXdveLW1OS7EmSdOfqjcgHlS1//ztgZ3Llh7KWCdo3rUltcu/sCExi38A8b?= =?us-ascii?Q?8Ktl5WPttA1/JHi8Giq9OfBt1w/aFGdW0WIhvrFgxXAo/evs0zv5eMQSvbJM?= =?us-ascii?Q?wWRJS1gFVSK2YYSk2A6KoGqX2AEP7UixjDlWm07PzjGUcZsQclKFbZIf3lzA?= =?us-ascii?Q?hP6uB0YR4fS2gjp9RsSeFjMkbnBqUAHp1ZcO2sv0o9u1v7Gd6377sLvjqb9a?= =?us-ascii?Q?sbmxQjxwMgxiKUrkVNxRmd1gUOXtfugT1NDjp2MzNWWQZ+tcfs5/acTb1ahs?= =?us-ascii?Q?THbVyX7jBr+icjW5Mslpb0enb1A443iq3ndqdio6GVs9L8FLyhwZQEJYWtQE?= =?us-ascii?Q?wINS9EyvPSA0dJ2aL0bwEAHKzK9M1Cgmmu3GXpVbR5mIwqymwpBfDM/siqKp?= =?us-ascii?Q?zaYPvdm56mujDw/bRAePNpXQqbT/JO24WmfaWOqJujx3X09Rp6xiitW+u4SV?= =?us-ascii?Q?joJkHv5n5aFbwiukh3M=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2619.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8309da3-b302-43f2-322d-08db88000186 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2023 02:29:40.9977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iWFoeuvMkpnEILYdRKxNBwuRqq+vsQslesngGyOqMSd7qsl5EZw30XGjpC4wZPAB X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5396 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org [AMD Official Use Only - General] > -----Original Message----- > From: Andrew Lunn > Sent: Tuesday, July 18, 2023 10:16 PM > To: Quan, Evan > Cc: rafael@kernel.org; lenb@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airlied@gmail.com; daniel@ffwll.ch; johannes@sipsolutions.net; > davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > pabeni@redhat.com; Limonciello, Mario ; > mdaenzer@redhat.com; maarten.lankhorst@linux.intel.com; > tzimmermann@suse.de; hdegoede@redhat.com; jingyuwang_vip@163.com; > Lazar, Lijo ; jim.cromie@gmail.com; > bellosilicio@gmail.com; andrealmeid@igalia.com; trix@redhat.com; > jsg@jsg.id.au; arnd@arndb.de; linux-kernel@vger.kernel.org; linux- > acpi@vger.kernel.org; amd-gfx@lists.freedesktop.org; dri- > devel@lists.freedesktop.org; linux-wireless@vger.kernel.org; > netdev@vger.kernel.org > Subject: Re: [PATCH V6 1/9] drivers core: Add support for Wifi band RF > mitigations > > > The wbrf_supported_producer and wbrf_supported_consumer APIs seem > > unnecessary for the generic implementation. > > I'm happy with these, once the description is corrected. As i said in ano= ther > comment, 'can' should be replaced with 'should'. The device itself knows = if it > can, only the core knows if it should, based on the policy of if actions = need to > be taken, and there are both providers and consumers registered with the > core. Sure, will update that in V7. Evan > > Andrew