Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0838ed9e-8b5c-cc93-0175-9d6cbf695dda@intel.com>
Date:   Wed, 19 Jul 2023 18:42:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH net-next] page_pool: split types and declarations from
 page_pool.h
Content-Language: en-US
To:     Yunsheng Lin <linyunsheng@huawei.com>
CC:     <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Wei Fang <wei.fang@nxp.com>,
        Shenwei Wang <shenwei.wang@nxp.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Geetha sowjanya <gakula@marvell.com>,
        Subbaraya Sundeep <sbhatta@marvell.com>,
        hariprasad <hkelam@marvell.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        "John Fastabend" <john.fastabend@gmail.com>,
        Felix Fietkau <nbd@nbd.name>,
        "Lorenzo Bianconi" <lorenzo@kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        "Shayne Chen" <shayne.chen@mediatek.com>,
        Sean Wang <sean.wang@mediatek.com>,
        "Kalle Valo" <kvalo@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
        <linux-rdma@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-wireless@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>
References: <20230719121339.63331-1-linyunsheng@huawei.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230719121339.63331-1-linyunsheng@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2ZBV0Rod3dnMHhxVnJqTEp0MlBXOENpNWxSMlhoZkRRcnVtS2pNREE3Z2M1?=
 =?utf-8?B?SkF2NWUvOG9BNEJrNWxkTVNTcTNxLzIrMWVpTHJhN1JSbVZxUGJuMEIwTi9W?=
 =?utf-8?B?YVBCcUY1cUo3N0FueFNGRVFBdC9XWkViMUVMTGV3NU1UNWtQNDVFOVcwY3NH?=
 =?utf-8?B?T01ZbmEvNW1DY0cvZFFzWHFybTcza0FRc3FDVkJacXg0VWZlSUY4bVh5RkRY?=
 =?utf-8?B?NTMvTmRYUmNna1d4ejltd294aTJQQ1A4a0ZZQVA5d0FyN3NyeGh1SUxNdE1Z?=
 =?utf-8?B?SWs5TndwYW9ZT1ZLdHY3Q0lzZktuRHowUmMxZS95VDN1SVBwL1lGUy93MTJv?=
 =?utf-8?B?cTViUTBwZkszTGRDdnl4ekwwelc5eEZtR2loMlZBZ29GYW84VUpXYlZIcHEv?=
 =?utf-8?B?MVNSVWF4SkhLM3g5c3pxV1ZBY21HeCtkdmp4UEdMVWQ2SzhqcVhTS3Y2dklo?=
 =?utf-8?B?dy94bk9uS1ZKNWU2TSs0VTQ2MUROVm5KNGp5eXoza1NuQmE3T09WRTJyYTls?=
 =?utf-8?B?am9mbktSTmxNaHBmVnZ2ZE4zME94aVNPSDlMUzdNRGlYVVJISzZKaXEvZEc4?=
 =?utf-8?B?eXZ1cVJKbnhIb1BsbXBLUlkremtFakhOb1FNY0Q4Ly94dW9ZY1NCMjFvUlBG?=
 =?utf-8?B?R0Z0eWR5OHRTWitzMG5lblhKbzRoR2tPKzc0SnJOdnR1V0lsZXBSZjltS0xW?=
 =?utf-8?B?VUNPTXpvUmVNVEdWU0szRE9vbGMxWCtwaFFCRmdteGtZdnYzbjYyeWs5MC9s?=
 =?utf-8?B?WW5jaVI5aGZrS2NEbUExSmthZWd0NU5tWVlGMHhrVy9OUXJtbUR2dlFwZ2h2?=
 =?utf-8?B?RE5aK3IzMk1LRDdlc3lmdFdwRW8rSHJBbTc3elJ2YThmTW9HM0w2VzQzMFli?=
 =?utf-8?B?aWNlV0NIdDZ4ZENQUGVoREttUVBQYUJLbWZBWFY5M1hJNnRGNVZEUjBsWWt3?=
 =?utf-8?B?NUlMdmUyNCtTb2c0NFlpazZzazc5M0xJa0dmYTd3NitKalBSTXlXYVhMd3Fv?=
 =?utf-8?B?d2dXd0pGYS9rL0ZsYmxnZmdHM1FVbUhEWlN1UmJPTG9jR0hjdWpaUFpBR3hO?=
 =?utf-8?B?T0ZIbVIyZWhGUCs1ckpJcXhLMmxNZzV0TXZVeVdZMmdFTmZQaExxdmRlYXdK?=
 =?utf-8?B?a21ORytDRmhqSDRiY1dFR1ZJQ2VPd29lV0ZqZ09LYytSNmNCRytUckpBUzVp?=
 =?utf-8?B?djhvcVJReXJkZi9ISWZUWFV3d3ZsdlFqcHJqVi9FaHNFU0gxVy92d1dYN3dU?=
 =?utf-8?B?c3lFVWZiWE1GZE9ydkd4d3VVSC91VWRFa2ZnRmV2WlBLQ2UyZ0ducmt6TXds?=
 =?utf-8?B?R1llVnh1WTBSQ3laSVl0NHpONmUwaFcvT20rSkdGZDlabFFRQ2FNdWFOd2JS?=
 =?utf-8?B?OTczcHhEZ041dlRCcUpEM0lXTWkrSGh5SWdaaUhwLzFpRlpCTVhkcW5IcUJB?=
 =?utf-8?B?dVJSY3B5NDhNZ25BeXh5TVFKckh6M2hEaWxyRER0SVBFSGJlUnY1K1g4MXRj?=
 =?utf-8?B?eG9uVkFEU21RQ0NYbmVQYXNBaUdMTkkycjkxbEhGVmwwcWViNllENGFlWXU1?=
 =?utf-8?B?aTRxMnhHTWVMaWZUd3Q3VHY2Sm8rRVFPMmxyajQxOVpEYXF0RVN3N1F4eXpI?=
 =?utf-8?B?Vmk1SHBTMEgxa2VLR3JhVTVldG5mYlZOWGtRT2FMQVhmVXNqaUdVMlkrZXRS?=
 =?utf-8?B?bmI1WldKaDZubFEyRGJ0Y3hoY05mYUp0Z2M1dXVNYlVLQkQ1Q1pIOGYzUDFH?=
 =?utf-8?B?cmhQN0NCelNSd29GSnBGYitXbUZ5ZmdmTUwraU9iOCt0c2tyc2gvZkZyazFR?=
 =?utf-8?B?VWk1ME92ZDZwZXU4U2VLcG56T2plMDdnWTdDU1M4ckFGTXFsM2s1akF6ajM3?=
 =?utf-8?B?TWJWM2JLRkYxT291dFQrZ1VJMmxSVmlsZHg5aFc3clB0TFQ0NCs5cGdOeFc2?=
 =?utf-8?B?WVUxbXhZL0tlSDRBZWxOYk5tbDBLQTQ3alFjbnVMdmZPS0piMFpRZkE1KzRk?=
 =?utf-8?B?Q1IycWpQRnlqelB2R2VWUGhwcFJYbFNyUTNsM0c4eXI2QmUrUFFkR1M0KzlB?=
 =?utf-8?B?QTFJdHhIOVFMK1ByMnNSbFl6NWlBanl4UWdIaEpvR2t6bDVmMkR1N1p6RStk?=
 =?utf-8?B?N3VjdCttQks2OFFkSkpFWCt3SytjSDZSL2lZSEVmQmtmMVF5MG5zWGtGcEhR?=
 =?utf-8?B?S2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 700a6d9f-b9d9-4533-62da-08db88776116
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 16:44:12.4485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: utzUQ3gRHeKqIpUwVtg2ACucnZOnc7c7ZGbEr5Cx2WPDw2WatVnCkPNSv8qZZNLWjdF3ni3xS7O4V2iMRJX3lADPfaiZrtgAdBCGk69NHNU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4561
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

From: Yunsheng Lin <linyunsheng@huawei.com>
Date: Wed, 19 Jul 2023 20:13:37 +0800

> Split types and pure function declarations from page_pool.h
> and add them in page_page_types.h, so that C sources can
> include page_pool.h and headers should generally only include
> page_pool_types.h as suggested by jakub.
> 
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> CC: Alexander Lobakin <aleksander.lobakin@intel.com>
Nice!

Let me take it into my tree, I assume it's safe to say it will be
accepted sooner than my patches :D

BTW, what do you think: is it better to have those two includes in the
root include/net/ folder or do something like

include/net/page_pool/
  * types.h
  * <some meaningful name>.h (let's say driver.h)

like it's done e.g. for GPIO (see include/linux/gpio/)?

Thanks,
Olek