Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp8524023rwp; Wed, 19 Jul 2023 11:02:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlHIhFYU+oHD28vSPV7IkfxVxyKenUAxG7a4eQGHIP4l+uDNVEteMgR39NLfT5l5cvMq9XIm X-Received: by 2002:a17:906:7395:b0:992:7295:61d4 with SMTP id f21-20020a170906739500b00992729561d4mr3345335ejl.3.1689789743144; Wed, 19 Jul 2023 11:02:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689789743; cv=none; d=google.com; s=arc-20160816; b=P9LKIei5TfKT4VgyRE7Q+r7fEf8J2HDb9dgcB5g4hbpYBgUN9WKpxbqeRidiGq5vm0 9KFsYgBzbWwsVcXGyloC+5rIBw8CACOph8fhGFpsT2EN5n52Td9RcW+PWjGKd1PyKOjt cad3ihj+WrPciCHjD3lB5y1+MYbx+cJnCPZ0CckREHEFDSOGCAU+eN7O2kTXacKDCprE 6NtiNYgNRRWK5WhV443SKfBWEhbyGBa3cpkmK1WJMkn6pC2TrA8SEKx99jZ3IqZIUG4g s9KgbelhGiZvbfWMJizfpaUHoPx2row2ekM7y97r2P+2F6xiecYcFVHyuozwKTYdhpXs cyBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=FNSwVas6f40XSnzFCl/wxKNhOZL/iwdgtkRrD84qjIU=; fh=+HFkYXbTQ8eG09g9vYxyj0jCb3UqA7wh0J7/VFlzRmg=; b=b3HEyySMovp/2nV4c961DllWIeNz/20z8VcpoMIEmcp/FHF/i4jDktZ8Fed+wmmPu/ XGeeQkA3Fvs9gXXx9pW2mwYFhL7+NJay7GjB6GSkF3wk++oCy+yVX/gMrBO2oYkbO6EK MNaGEhKG7ftUDGD/wubnfxJT55JxzXZNuI2oJPECsZcHER81VJFKZSVeqIMbA7KZupFq ymIoF6LkQdrzexL3f/aM8b44HrmuyG1Q8beNmX3yBL63T36CqDWvjATKmamoCwT8Pfgu NAxqL9pcNDdhZTA98JCknaAGdNmeqKdjvi8e3sy9Vf/USVRHSk0w56pmNXKfuoAVleKm A9/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YdriETaQ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o6-20020a1709062e8600b00987e4102ebfsi3097705eji.993.2023.07.19.11.02.02; Wed, 19 Jul 2023 11:02:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YdriETaQ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbjGSSAV (ORCPT + 59 others); Wed, 19 Jul 2023 14:00:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbjGSSAU (ORCPT ); Wed, 19 Jul 2023 14:00:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 553051FC1 for ; Wed, 19 Jul 2023 11:00:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DCD04617CF for ; Wed, 19 Jul 2023 18:00:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35C8AC433C7; Wed, 19 Jul 2023 18:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689789619; bh=FNSwVas6f40XSnzFCl/wxKNhOZL/iwdgtkRrD84qjIU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YdriETaQyzhulwFyTPXwrKYms+TTdOxo3vHfThCS8frvTobZo/A7cCuOdaV58lL6u 1FEvfc2zncfpnAijFLAGzJdBrMAtIedfk8wsFqjdLTojOarA8EiqNnfApg2gBWYiLT zznTO8z0jHhVgBfXx+/KP+7w9RXXn8kP0rDEmVkrLfjYZsc3qRE71+B+3xdzblk1gm comMRCCKX1JrSwYmzEpMsidcPfTMCzhlwnquitlltYGsvmdcDMekA36fZLpcbd+l+L t3vhotdQA3J8zbFqqTsEir2DpvwvLVQ7Fdh8e7Dg8v1i3EyWtWU6scAgM2b876HAHz FRmXN6cJHqmfA== Date: Wed, 19 Jul 2023 11:00:18 -0700 From: Jakub Kicinski To: Ilan Peer Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH] wifi: cfg80211: Fix return value in scan logic Message-ID: <20230719110018.565eff67@kernel.org> In-Reply-To: <20230719145120.739521-1-ilan.peer@intel.com> References: <20230719145120.739521-1-ilan.peer@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 19 Jul 2023 17:51:20 +0300 Ilan Peer wrote: > As cfg80211_parse_colocated_ap() is not expected to return a negative > value return 0 and not a negative value if cfg80211_calc_short_ssid() > fails. What's the user visible impact of this issue? > This bug was introduced in commit c8cb5b854b40f > ('nl80211/cfg80211: support 6 GHz scanning'). And if it does indeed have user-visible impact please use the formal Fixes tag format. > Signed-off-by: Ilan Peer