Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Pink Perfect <pinkperfect2021@gmail.com>, amitkarwar@gmail.com,
        ganapathi017@gmail.com, sharvari.harisangam@nxp.com,
        huxinming820@gmail.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] wifi: mwifiex: Fix OOB and integer underflow when rx
 packets
References: <20230713023731.2518507-1-pinkperfect2021@gmail.com>
        <CAKNAPeOvG1MVD0y5xuZpN8mSEzvrzcvRhdyrTJhju-_Z1nGV0g@mail.gmail.com>
        <20230713105644.49444826@kernel.org>
Date:   Thu, 20 Jul 2023 09:55:38 +0300
In-Reply-To: <20230713105644.49444826@kernel.org> (Jakub Kicinski's message of
        "Thu, 13 Jul 2023 10:56:44 -0700")
Message-ID: <87sf9j3wd1.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jakub Kicinski <kuba@kernel.org> writes:

> On Thu, 13 Jul 2023 10:44:56 +0800 Pink Perfect wrote:
>> Sorry, forgot to change the signoff name, after you review this patch I =
can
>> submit a new one
>
> Do you mean change to "Pink Perfect", is that the name you'd sign
> legal documents with?
>
>> On Thu, Jul 13, 2023 at 10:37=E2=80=AFAM pinkperfect <pinkperfect2021@gm=
ail.com>
>> wrote:
>>=20
>> > Make sure mwifiex_process_mgmt_packet and its callers
>> > mwifiex_process_sta_rx_packet and mwifiex_process_uap_rx_packet
>> > not out-of-bounds access the skb->data buffer.
>> >
>> > Fixes: 2dbaf751b1de ("mwifiex: report received management frames to
>> > cfg80211")
>> >
>> > Signed-off-by: pinkperfect <pinkperfect2021@gmail.com>
>
> No empty lines between tags, please.
>
> You mentioned reporting the problem to chromeos, since mwifiex
> "maintainters" seem to be AWoL, would someone from their team
> possibly be willing to venture a review tag for the patch?

We have four maintainers for mwifiex and total silence:

MARVELL MWIFIEX WIRELESS DRIVER
M:      Amitkumar Karwar <amitkarwar@gmail.com>
M:      Ganapathi Bhat <ganapathi017@gmail.com>
M:      Sharvari Harisangam <sharvari.harisangam@nxp.com>
M:      Xinming Hu <huxinming820@gmail.com>
L:      linux-wireless@vger.kernel.org
S:      Maintained
F:      drivers/net/wireless/marvell/mwifiex/

I'm very close of marking this driver as orphan unless anyone steps up.
This is not how to maintain a driver.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes