Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp9174697rwp; Thu, 20 Jul 2023 00:12:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlE+zOLak+3YgR8gTP2xq+a8Nb0HY2emNFjc0AmpQ74+5I04FZcqNzx3YdSWogLVO3bEngAT X-Received: by 2002:a17:906:53c7:b0:988:9ec1:a8c5 with SMTP id p7-20020a17090653c700b009889ec1a8c5mr4049339ejo.55.1689837172916; Thu, 20 Jul 2023 00:12:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689837172; cv=none; d=google.com; s=arc-20160816; b=bHQDs1+vu9zC9/cQDu9NEH7uT9Y89qPHoiUbGgiCT7s83WrYxFOUQOjG8IYsag7SV8 7t9dnr9FQv4yKz5UW7PWlu+6s6efeqkv22EWq7dhQ6NetyBMMzKcXMRsPBm6OtobHeb0 DtoXOTVQ1EDpAxkpZFqcnORLBH2XfpH5fnLLAsMp+aT39a2vxD7sp5KAaQXABRR5IUGl Si0Hn7qC63JGUsRSkq4qxvlFjhP5Ncian3R78tL8mlZBPWe9WGN0Vv9X5KaIrCJyeEI6 xxonCLn0u1IYhu3FQAfpqsbuLQxEPBGk1ncWQVzZ4IwTssRnDOJjg3+WqRAwhAbEZVgR e/cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=9JCi9GyX72+UboSMXWaAUr/RynGoHsTYHg+3TwaOVak=; fh=GOH+Qqh68zZ5rKZFWen8uMx1P6c01Fz3h6+zZ1V/Ogg=; b=KxAbTyvr/F4tCeXrDPmNTtenrAaUGu93saOQnlYUSRlc0hw49gbyynrtUVPZ7iyFVH ujI9TrmFOzMcMm7kNe0k31VJwVnil+shXwQFGPTF3XwIJGJYeqpm7DNtyRrizpZSpjJj 2PeQxmsVQLVwUK5eugWMEzekbZ3VF+JYiGaZK2lBWed6Jp5Gs+8SsuJVayX0fNvafJOf gZ/HeEdE0i+YezA/SLm9iSjnguY/6hEKAoQ1lY7mM70rGYdVtGk2WIYuCUDClPysqfan uXilIXkrZb3IXR04nKWBA4NExZ3gjv4znRmyWSc94EMwfHDn3iIiEVv/7NzYNfY/Ipw8 pQew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rW7A+yfN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bs10-20020a170906d1ca00b0097650856f55si277505ejb.695.2023.07.20.00.12.38; Thu, 20 Jul 2023 00:12:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rW7A+yfN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230088AbjGTG6N (ORCPT + 59 others); Thu, 20 Jul 2023 02:58:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbjGTG6M (ORCPT ); Thu, 20 Jul 2023 02:58:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A0A8110; Wed, 19 Jul 2023 23:58:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B0780618E3; Thu, 20 Jul 2023 06:58:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEB64C433C8; Thu, 20 Jul 2023 06:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689836290; bh=7mK4Ss6OHN/futLgmH2TgGuEhX+eZoCr1St7KNuM1Ak=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=rW7A+yfNq+AWVSYmbDooALBYl0/JFJ3+2+nqaxcFE8jj+p5JxoqT2khnsjgh/NzD9 oy7n8TGTAq5sTOFXmX07dK0eNxRn5eQOFHRuIX4QOzcQGTjlkskvQ+/FBt7QnG5QNu WMScSjUy6Wcfj06CO0yzFT7+i9MFU0XPPwC6D3VyiSsLMPVsR6K/xaajGcg1YZ26RI cPxX6RLsQIRDFucf2itNBo3a2TiiU9Ov34Dg6dfQZq4EFVTa87sonvVs6bTkLeK4ca 6cLwcC/AjZ2bdrlFAdycmJmm86n9iOti6KwaFBgYGY0gMo7KCw86a2U8AYyGr9S7Nt ry2p3who6IsSA== From: Kalle Valo To: Paolo Abeni Cc: Wang Ming , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH net v1] ath6kl:Fix error checking for debugfs_create_dir() References: <20230713040518.13734-1-machel@vivo.com> Date: Thu, 20 Jul 2023 09:58:06 +0300 In-Reply-To: (Paolo Abeni's message of "Thu, 13 Jul 2023 11:29:30 +0200") Message-ID: <87jzuv3w8x.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Paolo Abeni writes: > On Thu, 2023-07-13 at 12:05 +0800, Wang Ming wrote: >> The debugfs_create_dir() function returns error pointers, >> it never returns NULL. Most incorrect error checks were fixed, >> but the one in ath6kl_debug_init_fs() was forgotten. >> >> Fix the remaining error check. >> >> Signed-off-by: Wang Ming >> >> Fixes: 9b9a4f2acac2 ("ath6kl: store firmware logs in skbuffs") > > The SoB tag should be after the 'Fixes' one and you must avoid empty > lines in between. > > (The same applies to your other patch) And the same as with the ath9k patch: this should go to ath-next, not net. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches