Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Brian Norris <briannorris@chromium.org>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        Pink Perfect <pinkperfect2021@gmail.com>, amitkarwar@gmail.com,
        ganapathi017@gmail.com, sharvari.harisangam@nxp.com,
        huxinming820@gmail.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] wifi: mwifiex: Fix OOB and integer underflow when rx
 packets
References: <20230713023731.2518507-1-pinkperfect2021@gmail.com>
        <CAKNAPeOvG1MVD0y5xuZpN8mSEzvrzcvRhdyrTJhju-_Z1nGV0g@mail.gmail.com>
        <20230713105644.49444826@kernel.org> <87sf9j3wd1.fsf@kernel.org>
        <ZLlrd4dDz+kA5l18@google.com>
Date:   Fri, 21 Jul 2023 10:15:25 +0300
In-Reply-To: <ZLlrd4dDz+kA5l18@google.com> (Brian Norris's message of "Thu, 20
        Jul 2023 10:14:31 -0700")
Message-ID: <87tttx3fci.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Brian Norris <briannorris@chromium.org> writes:

> On Thu, Jul 20, 2023 at 09:55:38AM +0300, Kalle Valo wrote:
>> We have four maintainers for mwifiex and total silence:
>> 
>> MARVELL MWIFIEX WIRELESS DRIVER
>> M:      Amitkumar Karwar <amitkarwar@gmail.com>
>> M:      Ganapathi Bhat <ganapathi017@gmail.com>
>> M:      Sharvari Harisangam <sharvari.harisangam@nxp.com>
>> M:      Xinming Hu <huxinming820@gmail.com>
>> L:      linux-wireless@vger.kernel.org
>> S:      Maintained
>> F:      drivers/net/wireless/marvell/mwifiex/
>> 
>> I'm very close of marking this driver as orphan unless anyone steps up.
>> This is not how to maintain a driver.
>
> I'd be fully on board with removing these maintainers, as I don't recall
> hearing from any of them in years. (In fact, some of these addresses
> don't have a single mail logged on lore.kernel.org/all/...) I just
> didn't want to be the one to say it.
>
> On the other hand, I regularly look at pretty much anything for mwifiex,
> as long as the submitter is in relatively good faith. So I wouldn't mind
> being a Reviewer (or Maintainer? what's the difference, when Kalle
> does the committing anyway?).

Heh, that's a good question. I don't know what was the original intent
for a reviewer role but in my view ideally a driver should 1-2
maintainers, no more, and if there are more people involved they should
be reviewers. And maintainers should use Acked-by, Reviewers should use
Reviewed-by. And if I see an Acked-by from a maintainer I usually don't
review the patch so closely and just take it directly (of there are
exceptions, as always). In this case I would prefer you being the
maintainer, even if you wouldn't have much time for mwifiex.

But I don't know how others see it. Jakub has been writing documentation
about maintainership which is also a good read:

https://lore.kernel.org/all/20230719183225.1827100-1-kuba@kernel.org/

> And that might qualify as "Odd Fixes", as
> I don't plan on doing much more than keeping the lights on.
>
> I'll submit the MAINTAINERS patch if you'd like.

Sounds very good to me, thank you! Please submit the patch if you can.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches