Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp2836120rwo; Mon, 24 Jul 2023 01:53:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlG4pHZzU4bwNC28J9NMRJTJ6KcZePKtMZcmDuesCV9SHAdt4D/3RjmhG7stiYCc3r7R+1Rs X-Received: by 2002:a17:906:3f56:b0:99b:492d:25fa with SMTP id f22-20020a1709063f5600b0099b492d25famr8800314ejj.76.1690188793107; Mon, 24 Jul 2023 01:53:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690188793; cv=none; d=google.com; s=arc-20160816; b=ZlzuRtjMBHKTkV878MwtB1uPyhfQCRE1TMIUByr0a9wltQJOSk/Goo17K7UO+l8FqZ NA+0kfUJ7Pg2BgJoUob17gGlkwF+1NeCIAKG0pecOWZFvW9gy5i7j5WqxCK44DTPSwSZ ohr/gTDWrmD2iQm6xzzf0QwWzyihxpJdOeHJ6GII88EiHAIYlMTMAO/KLtBDiV6s2T55 t3AjYn2t6OB8yDB4AMqf6W1d7cE+PjMjU5oV74JiJLd3zJXPxbg72a56NgxrPwyd8rkB EdIvKevPFyzFLke21XTWllN1AZosrA7OT2iCV7Q/J4T/8gRU9Fo5AeLEPQeb08B33wCD XUyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=WVRDTSuqwhQYr0iyHkC8g0h1lLfYfMsqY1SBsRXxG0Q=; fh=UGNESuWdWk2VC4r/o2u7qM6gEirML+nFlwpx86ixvK0=; b=d0sex3a16Qsvi2Hy+viga8rO25le3bb5wjyBOciQszSNDAcs/y9cg9CKjDnzqpSOYj k9e08KelJ6Zg9nxkFjhDJTrznD66MVVK7sR199XyErWeZHFWO9MsVSW0UhjfxhF8XUh+ cI7Pg1FQftnW5XKiGtwJ0DUrtfMICBfY5YXwg+n96fp2erZTE7oXTLMLIIL6rspfCFi5 mFh5b1WrYKLrh2hQAVIZTh4445rARId+kKkLgVdyVb7Cy30Nlmc/F5pOu7b9yKuFip3Z uk65rdUATDjpLIKPqqGipo0irNdgnXZk/IqD/5xXLeseG0ldJ2nQIkArkLvytO1kXY3A bHVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=O+oWMBBG; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gw14-20020a170906f14e00b0099ba1cf9543si392458ejb.460.2023.07.24.01.52.52; Mon, 24 Jul 2023 01:53:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=O+oWMBBG; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231200AbjGXIpe (ORCPT + 58 others); Mon, 24 Jul 2023 04:45:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231809AbjGXIpP (ORCPT ); Mon, 24 Jul 2023 04:45:15 -0400 Received: from forward103c.mail.yandex.net (forward103c.mail.yandex.net [IPv6:2a02:6b8:c03:500:1:45:d181:d103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C45A410CF for ; Mon, 24 Jul 2023 01:45:11 -0700 (PDT) Received: from mail-nwsmtp-smtp-production-main-77.iva.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-77.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:5e29:0:640:21c5:0]) by forward103c.mail.yandex.net (Yandex) with ESMTP id 02AAD60155; Mon, 24 Jul 2023 11:45:09 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-77.iva.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 8jE97fQDSuQ0-NZaXUhPc; Mon, 24 Jul 2023 11:45:08 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1690188308; bh=WVRDTSuqwhQYr0iyHkC8g0h1lLfYfMsqY1SBsRXxG0Q=; h=Message-ID:Date:Cc:Subject:To:From; b=O+oWMBBGqyPFwi+mRMn6hlO1UTm0oKJ39xxD3Ny3Jw+BAWJbBtGYOfxjISyT2QCvD kl6WCpY3wHsLN0HPAMzrLg5sbFVhnNkvRIv5GSjrG+bGBsbdXigHZO82BsQWrjJWyM OR+0vNrHoEiN+Z/4SEvdJmKuSudsbUBunZqE9iAw= Authentication-Results: mail-nwsmtp-smtp-production-main-77.iva.yp-c.yandex.net; dkim=pass header.i=@yandex.ru From: Dmitry Antipov To: Kalle Valo Cc: Doug Brown , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, Dmitry Antipov Subject: [PATCH 1/4] wifi: libertas: add missing calls to cancel_work_sync() Date: Mon, 24 Jul 2023 11:44:40 +0300 Message-ID: <20230724084457.64995-1-dmantipov@yandex.ru> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Add missing 'cancel_work_sync()' in 'if_sdio_remove()' and on error handling path in 'if_sdio_probe()'. Signed-off-by: Dmitry Antipov --- drivers/net/wireless/marvell/libertas/if_sdio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/marvell/libertas/if_sdio.c b/drivers/net/wireless/marvell/libertas/if_sdio.c index a63c5e622ee3..a35b33e84670 100644 --- a/drivers/net/wireless/marvell/libertas/if_sdio.c +++ b/drivers/net/wireless/marvell/libertas/if_sdio.c @@ -1233,6 +1233,7 @@ static int if_sdio_probe(struct sdio_func *func, flush_workqueue(card->workqueue); lbs_remove_card(priv); free: + cancel_work_sync(&card->packet_worker); destroy_workqueue(card->workqueue); err_queue: while (card->packets) { @@ -1277,6 +1278,7 @@ static void if_sdio_remove(struct sdio_func *func) lbs_stop_card(card->priv); lbs_remove_card(card->priv); + cancel_work_sync(&card->packet_worker); destroy_workqueue(card->workqueue); while (card->packets) { -- 2.41.0