Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b28c02a8-8263-47e3-ffcf-51c992f03d30@intel.com>
Date:   Mon, 24 Jul 2023 12:18:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH net-next] page_pool: split types and declarations from
 page_pool.h
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>
CC:     Yunsheng Lin <linyunsheng@huawei.com>, <davem@davemloft.net>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Eric Dumazet <edumazet@google.com>,
        Wei Fang <wei.fang@nxp.com>,
        Shenwei Wang <shenwei.wang@nxp.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Geetha sowjanya <gakula@marvell.com>,
        "Subbaraya Sundeep" <sbhatta@marvell.com>,
        hariprasad <hkelam@marvell.com>,
        "Saeed Mahameed" <saeedm@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        "Alexei Starovoitov" <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "Jesper Dangaard Brouer" <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        "Ryder Lee" <ryder.lee@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        "Sean Wang" <sean.wang@mediatek.com>,
        Kalle Valo <kvalo@kernel.org>,
        "Matthias Brugger" <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        <linux-rdma@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-wireless@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>
References: <20230719121339.63331-1-linyunsheng@huawei.com>
 <0838ed9e-8b5c-cc93-0175-9d6cbf695dda@intel.com>
 <7e9c1276-9996-d9dd-c061-b1e66361c48b@huawei.com>
 <20230720092247.279d65f3@kernel.org>
 <f5d40062-bb0d-055b-8c02-912cfd020aca@huawei.com>
 <20230721075615.118acad4@kernel.org>
 <ccb728be-832c-be93-2023-6a5c78c53e6a@intel.com>
 <20230721182942.0ca57663@kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230721182942.0ca57663@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHJEeEN4eE14SWUydmJ3RjBzMEdDZUU0VVQxb3A2WG12MWJNZWN2eUN0SHBv?=
 =?utf-8?B?b2gzSGRtTERHNEROSEpKMTB4c3ZXNEVlcWlGTTB0WnBwQmxYejRrZFBxdmQv?=
 =?utf-8?B?T2tIbUFVWWY3UXNYR2lrMGROaUsxclFzTzZ3SzVMd1loaytjUTVkUER1Q3Ay?=
 =?utf-8?B?WEVLakZTNWd0RUQrYjFjM0tvellGRGZWV2dSdjBZT0Q3REVqbVJjTWhKVytQ?=
 =?utf-8?B?QnVUV3JRY1ptRTdpM1lYVWxLdkwyYTZVRk84V29vMTUrTjd2M2hpbXNtdjJV?=
 =?utf-8?B?RjdOdHpieVV6bmdDTXBNaVJTQ01QSVlDMVVJZHhQcG03ekNWTytvV0VSRkpi?=
 =?utf-8?B?N2NoVkd3aVNqWEliQUt3TkJMNC8wTlJtZW5MbkcvU1kzYkEvSzFMZStGYmFi?=
 =?utf-8?B?Z0Z3cFV5RWxrbTVERWtjdlBtNXgwTVJSa3VSNTdkMWFIYzVkL3Fyd3dNUHFp?=
 =?utf-8?B?NmdpaUcraXRlTzRMTGNIVC92T0xzdG9udmIvaUdTZ3BTaWNPUzlwaytEZE1R?=
 =?utf-8?B?dEVNcVhjbWd5enhOc2dyaXRraWlZZEZPS21HTGFFTU5nOTVPREN6cXNRcm1O?=
 =?utf-8?B?QjVqNXJQU0ViaGU1YXArNHhzamRjV1h1N0gzaEhjQVNOY2JYTWV1ZjJxQUZE?=
 =?utf-8?B?dlJkbVFwZytGNXFOUXFySnNzcUs0UktjRTRPZWw0dnk1MDB5bUNpOGNFemIv?=
 =?utf-8?B?bWxNMVdBOGZyNW1VeHV2bDVjaGpLeldEY2xMZUpRakFRSTFsUXF3VHFmSHRF?=
 =?utf-8?B?TTdZc0dpNW1nUzlzNTlmcml5VXd0Zkp6Rzh2NVdjZitNTnZvM0ROSmM2QU14?=
 =?utf-8?B?RW8vekluOWNBeWQra2grblpMemNlT2s1blVEWVhDQVljZmdwUkZCaVN2L0ZN?=
 =?utf-8?B?TGMvOE4zdWQ5MkRJVThnckEwQzFTOHFPc2NPTHVvQ053S2p2TFJSQ1VmL0lF?=
 =?utf-8?B?a0tQQk1yS3BMOWhaSzBEc3diVkZzZit5cThoNkRIUldrKzQ0RUs0ODZ1V0hL?=
 =?utf-8?B?RWRCMUFIcHQ3dnAwK0ZWYXNjR3pqOEc3UDMySE1ZVVJWMUlaejlEdlE5VE9G?=
 =?utf-8?B?b2hiNHdGS2c5bnRqZ0wzTm56RnhLeHlvRUQyNjNiS1E1UXN3aEtDRWcvOVlN?=
 =?utf-8?B?YUpBTHp6R0g4VytDQjNLa3EzUFlvb01ud3RoSEp3dUoydGc1dmM0c2EycHB2?=
 =?utf-8?B?RUNwMEdjb1gxODEwd1JwN3Nzdlc2eGkxanJlMEU2U3dHR3MzaTJPaUlDc0NE?=
 =?utf-8?B?U3dKRUVrZjJZWXdNcjIvdGR4b0h1bFFMckkvcEVWNncvckhVN2xSRElvdVJq?=
 =?utf-8?B?SjlqekVuUjdEd1grdS9OQVRwWlBHV1UyQnY1ejVUaGp5UkZrd3ZDeXZzdzBS?=
 =?utf-8?B?OFRKbUwrZUFGaXMvVi8rdnN6TzBmLzBHZGhCREN1SW5hS1lZclllYWVxRVJs?=
 =?utf-8?B?RFBtSjlrTkFxZVNWUUF6MlltMVh3dXg4czJTdjBWNHJRL2QrTEgyaEg3SnN0?=
 =?utf-8?B?aVEzbjFvRHdtdkx6dXFjNlo5Q0pZaUdPajBQQkEzSFhOaHVMRG5mMHBvL3k5?=
 =?utf-8?B?dTRVL25UN1hXTzdYZkdpUmp3Tld1UjVyOStSNjg1a0J1MmNaaU5tZXlUZHpP?=
 =?utf-8?B?YWNQU1VPZ0hqVHRMMTUzVm9kS09yR2FZY3lRZzA0d3VVcGNCN2x5YjEyT1I0?=
 =?utf-8?B?M2xCeXI3WURlSGFNZmlscDlUWG9HMzVMdlJsUG14VXRGY3pUVEhoR1VSZnIz?=
 =?utf-8?B?MkxxZmFyZzAvczZWUDlUK0tMTWMzMk5ZUzkwWnFDeDBkSDc0c0hHS3l3WkU3?=
 =?utf-8?B?K2NUVm4xNTB4R09waVd3NGw2TVFNUVNyc1JmbExGZG9NQkhHT3BQM3B4Q2RV?=
 =?utf-8?B?azY4TEs4QWhaTjNCUjdZa2MyaENqSk94OFdIK25yWDFuNm5iU3JaYjNSM0F5?=
 =?utf-8?B?QzlURi9yaUFwbXdXaDRiQjArMWo4bGt4QWt1RThXR0sybXpIckY2T09TeEVI?=
 =?utf-8?B?aHYwZEZLYjRzVUxjU2ppelpZTXZDMHhQL1lmWUdQM2hPQVp4NzdZeHJkTktP?=
 =?utf-8?B?Y0lIZmUvakE4SkozVG9oK0FlRWpkS2NXeUI5Q1kwb2d0VGd0S0syMC9EdFVP?=
 =?utf-8?B?V1BGaXJVNlFwOFo3VmNrQi9lYVV6MUJIbjFySjlpR09KaHcyMkZxbCtad0Fr?=
 =?utf-8?B?a0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f7478ff-2e68-479d-d798-08db8c2f8d2f
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 10:20:06.6307
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +TL2Q7TyOIolAbY79Cl04XWkcrxHCPh+pXCIucwP/RSnfKmHbPXpJeBfqHNIbnfq9WldxPzNpdpjmld6vr5BhWYbiOGEULWQu6ap8yzFBfc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4602
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 21 Jul 2023 18:29:42 -0700

> On Fri, 21 Jul 2023 17:51:17 +0200 Alexander Lobakin wrote:
>>>> More specificly, yon means the below, right?
>>>> include/net/page_pool.h
>>>> include/net/page_pool/types.h  
>>>
>>> Yes.  
>>
>> What I meant is
>>
>> include/net/page_pool/types.h
>> include/net/page_pool/driver.h
>>
>> I'm not insisting, just to be clear :)
> 
> I thought we already talked about naming headers after the user :S
> Unless you're _defining_ a driver in driver.h that's not a good name.
> types.h, helpers.h, functions.h, dma.h are good names.

Ah, sure :) I was mostly talking about

include/net/page_pool.h
include/net/page_pool/types.h

vs

include/net/page_pool/helpers.h (or functions.h)
include/net/page_pool/types.h

I.e. whether to have a header with the same name next to the folder or
place everything in that folder.

Thanks,
Olek