Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5a0e5c52-d4ec-3dd3-47c7-2d6bc098c440@quicinc.com>
Date:   Mon, 24 Jul 2023 10:43:49 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v4 00/11] wifi: ath12k: (v4) EHT support
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>
CC:     <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
References: <20230602235820.23912-1-quic_alokad@quicinc.com>
 <87y1klaqw0.fsf@kernel.org>
From:   Aloka Dixit <quic_alokad@quicinc.com>
In-Reply-To: <87y1klaqw0.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/15/2023 4:47 AM, Kalle Valo wrote:
> Aloka Dixit <quic_alokad@quicinc.com> writes:
> 
>> Add driver support for EHT bring-up, association and
>> preamble puncturing.
>>
>> v4: Modified patch 3 to support WCN7850.
>> v3: Modified patches 6 and 9 to fix some issues,
>> changelog included in the respective patches.
>> v2: This version modifies only few commit descriptions,
>> changelog included in the respective patches.
> 
> I did some minor changes to these patches in the pending branch, here's
> a list:
> 
> * patch 3: ath12k_wmi_tlv_mac_phy_caps_ext(): remove unncessary cast and add const
> 
> * patch 3: shorten struct ath12k_wmi_mac_phy_caps_ext_params due to
>    long line warning
> 
> * patch 3: improve error messages
> 
> * patch 3: move struct ath12k_fw_pdev after struct ath12k_pdev
> 
> * patch 5: ath12k_mac_get_phymode_eht(): add extra spaces, improve error messages
> 
> * patch 6: cosmetic cleanup, extra lines etc
> 
> * patch 6: ath12k_mac_set_eht_ppe_threshold(): move declarations
>    to the beginning of the function
> 
> * patch 7&8: use BIT() for enum wmi_tlv_peer_flags_ext
> 
> I have two more comments which I'll send as a reply to patches. I'm
> hoping to fix those in my pending branch as well so there would no need
> to resend anything.
> 
> The changes are now in the pending branch, under tag
> ath-pending-202306151144. Here's a link to few of those commits:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=974310a085acad9cee462b3f343e8c05185abc67
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=e4b7f51541b4ae79baa1ab9a8389fd4d9e0fe219
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=ae4b76c40bc7350d52d42de6e8633f6e52d905fb
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=3594ef351ae29788c00fad6c69d60b9a41dc1bbb
> 


Hi Kalle,

I have created a new version which fixes the comments you added 
separately for 2 patches.
Should I send those now?

Thanks.