Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cdfbb85a-f3be-8cdc-7117-7550d3808a13@quicinc.com>
Date:   Mon, 24 Jul 2023 11:24:19 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v4 06/11] wifi: ath12k: prepare EHT peer assoc parameters
To:     Wen Gong <quic_wgong@quicinc.com>, <ath12k@lists.infradead.org>,
        <linux-wireless@vger.kernel.org>
CC:     Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
References: <20230602235820.23912-1-quic_alokad@quicinc.com>
 <20230602235820.23912-7-quic_alokad@quicinc.com>
 <f4515520-1d3b-1b07-6ddd-ae269c12a91f@quicinc.com>
Content-Language: en-US
From:   Aloka Dixit <quic_alokad@quicinc.com>
In-Reply-To: <f4515520-1d3b-1b07-6ddd-ae269c12a91f@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/24/2023 3:16 AM, Wen Gong wrote:
> On 6/3/2023 7:58 AM, Aloka Dixit wrote:
>> ...
>> +    default:
>> +        if (arg->peer_phymode == MODE_11BE_EHT20) {
>> +            const struct ieee80211_eht_mcs_nss_supp_20mhz_only *bw_20 =
>> +                    &eht_cap->eht_mcs_nss_supp.only_20mhz;
> 
> When ath12k used as station mode, it entered here as well as AP mode.
> 
> But remote is AP device for station mode, then remote AP device do not 
> have the only_20mhz data(EHT-MCS Map (20 MHz-Only Non-AP STA)).
> 

What issue are you seeing? Please elaborate.

The default case will be entered for both AP and non-AP STA modes for 
all bandwidths.

If the device is a 20-MHz-only device, it will skip 320, 160 and 
directly enter the default case where 'if' condition will be true.

If the device is not a 20-MHZ-only device then it will enter the 'else' 
condition after processing 320 and 160 as applicable.

> Also 20 MHz should be same for 5 GHz/6 GHz(MODE_11BE_EHT20) and 2.4 
> GHz(MODE_11BE_EHT20_2G), right?
> 

Good point, I will add a check for MODE_11BE_EHT20_2G as well here.

>> +
>> +            ath12k_mac_set_eht_mcs(bw_20->rx_tx_mcs7_max_nss,
>> +                           bw_20->rx_tx_mcs9_max_nss,
>> +                           bw_20->rx_tx_mcs11_max_nss,
>> +                           bw_20->rx_tx_mcs13_max_nss,
>> +                           &rx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_80],
>> +                           &tx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_80]);
>> +        } else {
>> +            bw = &eht_cap->eht_mcs_nss_supp.bw._80;
>> +            ath12k_mac_set_eht_mcs(bw->rx_tx_mcs9_max_nss,
>> +                           bw->rx_tx_mcs9_max_nss,
>> +                           bw->rx_tx_mcs11_max_nss,
>> +                           bw->rx_tx_mcs13_max_nss,
>> +                           &rx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_80],
>> +                           &tx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_80]);
>> +        }
>> +
>> +        arg->peer_eht_mcs_count++;
>> +        break;
>> +    }
>> +}
>> +
> 
> ...