Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authenticated-By: 
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Larry Finger <Larry.Finger@lwfinger.net>,
        Kalle Valo <kvalo@kernel.org>
CC:     Johannes Berg <johannes@sipsolutions.net>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "Takashi Iwai" <tiwai@suse.de>
Subject: RE: [PATCH] wifi: rtw89: Fix loading of compressed firmware
Thread-Topic: [PATCH] wifi: rtw89: Fix loading of compressed firmware
Thread-Index: AQHZvl45NTY6Zd5s70uHF7Bey25uoK/JzMmQ
Date:   Tue, 25 Jul 2023 03:40:35 +0000
Message-ID: <fa4609f5720a4affa2bb4ace61800df5@realtek.com>
References: <20230724183927.28553-1-Larry.Finger@lwfinger.net>
In-Reply-To: <20230724183927.28553-1-Larry.Finger@lwfinger.net>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk


> -----Original Message-----
> From: Larry Finger <larry.finger@gmail.com> On Behalf Of Larry Finger
> Sent: Tuesday, July 25, 2023 2:39 AM
> To: Kalle Valo <kvalo@kernel.org>
> Cc: Johannes Berg <johannes@sipsolutions.net>; linux-wireless@vger.kernel.org; Larry Finger
> <Larry.Finger@lwfinger.net>; Ping-Ke Shih <pkshih@realtek.com>; Takashi Iwai <tiwai@suse.de>
> Subject: [PATCH] wifi: rtw89: Fix loading of compressed firmware
> 
> When using compressed firmware, the early firmware load feature will fail.
> In most cases, the only downside is that if a device has more than one
> firmware version available, only the last one listed will be loaded.
> In at least two cases, there is no firmware loaded, and the device fails
> initialization. See https://github.com/lwfinger/rtw89/issues/259 and
> https://bugzilla.opensuse.org/show_bug.cgi?id=1212808 for examples of
> the failure.
> 

Personally, I'm fine to avoid loading partial firmware, because of limitation of
compressed firmware. What I care is driver probe time, so I measure the time
100 times and remove the highest/lowest 5% numbers, and then get the average
probe time of 8852BE:
  Without this patch: 342,245,770ns
  With this patch:    346,473,726ns

This patch increases about 4ms that can be acceptable. 

[...]

> 
> Fixes: ffde7f3476a6 ("wifi: rtw89: add firmware format version to backward compatible with older drivers")
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

Tested-and-acked-by: Ping-Ke Shih <pkshih@realtek.com>