Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp4067492rwo; Mon, 24 Jul 2023 23:24:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlFY6piMEmzk9PsS44q7QVOGzo98/mq0Omks/4Ow630tFFNAeR0o58p8+d+hwFokwN7/lHps X-Received: by 2002:a17:906:7a53:b0:98e:933:2909 with SMTP id i19-20020a1709067a5300b0098e09332909mr12177301ejo.22.1690266253264; Mon, 24 Jul 2023 23:24:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690266253; cv=none; d=google.com; s=arc-20160816; b=RxsiST5NmYaZ15HVfw/qBJjsQLk5UjInk3NzutbsBHrDsdZ+lpXWF45k/4gBFHwtJh 5rQAuapZMZNjm0fcdHPyfdfDQQMABIf+/+EnxDQ2P8Tc5gl4seLKEG5o3xtOsRtcLltf rQhIvuhhN0f8/DFBwR0dqbNhR1gAsYmeTof2AJbgDeVL76SVbmy4Zb69J2UAU2Y18GhA Tng6q8a51ykQXrqc1jarjcGIHNrHsfrlD+QNhExdWhSx6Q/H4K5yViTWpLtKatjWn7cC KBxM8ZAId6KceYpU6NwZEh5+fdmObBndidvUkWSC3BjYD6rRsiKVv2LJ4krexZixkKGv 4xxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WVRDTSuqwhQYr0iyHkC8g0h1lLfYfMsqY1SBsRXxG0Q=; fh=I5fOnx9RJtxIVKWx6xJQIs4yQVAxO1NGLpxHU8vK4oo=; b=cVwLTJQj2CVPHC8I/hsW8Kvp5Q1A4U71JjCc6up26+ROQu+xNq3zH6Qc5BLMlXyuNv WrzOsVp+xmtaMFvRjQufwK4ffmsipSKFg+/LSfnw/9leOTpG2mJvXOpzqp+hjLnD/ohD X2sx5747CV6tgU1HSncryOGscYyA4YZOcXmMcyCUiKYK7zriP+zggvz4W9y1svvF01GZ l7H5AN0ucx4bPPbijr9fn0YwanZEfZ0K+ygFF214y3F5mTsXbUh798W3gtbU/deDuCh4 XYkU6ibIdJ4UdXan64IqKxAlNmkla4+KKP4Hc3Hv2glHYVgLGbiVSmi0Xyf8qFtAaMeY bXwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=GjPJv1eK; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kq7-20020a170906abc700b009893415be37si7180312ejb.501.2023.07.24.23.23.53; Mon, 24 Jul 2023 23:24:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=GjPJv1eK; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231974AbjGYGFt (ORCPT + 58 others); Tue, 25 Jul 2023 02:05:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231962AbjGYGFm (ORCPT ); Tue, 25 Jul 2023 02:05:42 -0400 Received: from forward100b.mail.yandex.net (forward100b.mail.yandex.net [IPv6:2a02:6b8:c02:900:1:45:d181:d100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B9D51BE2 for ; Mon, 24 Jul 2023 23:05:36 -0700 (PDT) Received: from mail-nwsmtp-smtp-production-main-45.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-45.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:552b:0:640:471f:0]) by forward100b.mail.yandex.net (Yandex) with ESMTP id 7328D600DE; Tue, 25 Jul 2023 09:05:34 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-45.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id X5DgcxaDR0U0-r0WZq22m; Tue, 25 Jul 2023 09:05:34 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1690265134; bh=WVRDTSuqwhQYr0iyHkC8g0h1lLfYfMsqY1SBsRXxG0Q=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=GjPJv1eKg3G4clq6NcG/R1ykW+a1X2Ec10CNXYEIQ5m6KPgq2CR6psvXGKHIhUcJS vJXWQXrGKt16+HPjbRUgonfPC6/k5KP9O1fWaG2Uiz+FyCKWepkzBgHHqYi5GNIKfg XcxNmQwLC1ERijiCO10pyj7V0X/SE/xD8Ge/NW/0= Authentication-Results: mail-nwsmtp-smtp-production-main-45.myt.yp-c.yandex.net; dkim=pass header.i=@yandex.ru From: Dmitry Antipov To: Dan Williams Cc: Kalle Valo , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, Dmitry Antipov Subject: [PATCH 1/6] [v2] wifi: libertas: add missing calls to cancel_work_sync() Date: Tue, 25 Jul 2023 09:04:43 +0300 Message-ID: <20230725060531.72968-1-dmantipov@yandex.ru> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Add missing 'cancel_work_sync()' in 'if_sdio_remove()' and on error handling path in 'if_sdio_probe()'. Signed-off-by: Dmitry Antipov --- drivers/net/wireless/marvell/libertas/if_sdio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/marvell/libertas/if_sdio.c b/drivers/net/wireless/marvell/libertas/if_sdio.c index a63c5e622ee3..a35b33e84670 100644 --- a/drivers/net/wireless/marvell/libertas/if_sdio.c +++ b/drivers/net/wireless/marvell/libertas/if_sdio.c @@ -1233,6 +1233,7 @@ static int if_sdio_probe(struct sdio_func *func, flush_workqueue(card->workqueue); lbs_remove_card(priv); free: + cancel_work_sync(&card->packet_worker); destroy_workqueue(card->workqueue); err_queue: while (card->packets) { @@ -1277,6 +1278,7 @@ static void if_sdio_remove(struct sdio_func *func) lbs_stop_card(card->priv); lbs_remove_card(card->priv); + cancel_work_sync(&card->packet_worker); destroy_workqueue(card->workqueue); while (card->packets) { -- 2.41.0