Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp4540738rwo; Tue, 25 Jul 2023 07:33:31 -0700 (PDT) X-Google-Smtp-Source: APBJJlHnAH9OCL8Yk+R2nN9ma7t8ipuxvxnwljfrkGpJaS7nyHURdteIaYp9uWIegpjPR88JVSF4 X-Received: by 2002:a05:6a20:117:b0:133:dd1b:aa57 with SMTP id 23-20020a056a20011700b00133dd1baa57mr9249181pzr.18.1690295611106; Tue, 25 Jul 2023 07:33:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690295611; cv=none; d=google.com; s=arc-20160816; b=VU6sQpOwuQ9NGOuomB5XZ+PHqjPcr7ct4DyqtfZHHway6uRtIq1/v467yTim237r2E Va5iJxWVoyw/QGzGHiLXiRakVFAPt9y7uDgGGjFT9VK3YefHSlC82OWhDu3DS+/z8vDD EHbz4+NL9N8pQlDJBwczYSRKXjC42NPlsSH/EI7Nl1q32aFOMGB4fSwv146Lj3jjOB+L heSzBSfS1JQlT0uZlA42BVhHxf50dnHRpwnmH65H+3fGKpdVLB3PTLhXShhwP3BLprwU 5Ix+0JTMChQNMG9OufsrkJGUgVi21kR+961JEMXwdi0jVgNAos2yoIYuNkzO0A0eRhwp p/kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=Nsdthwwb4uxlXEJi+pt1Wpwb79gybcBJRSiLtYLcQnk=; fh=SAmop4kM7qu8UhkJcMR/YLjMB8fcJyx8CEwIYQmCFWA=; b=D9tvShazEc//iAGNz5qqW1BQAInUzxuHZJmJ/NzfovRcB4h0Cd8w8kdC0FV3VV7wiQ QzndND08sxX9X2KUTcbBYg5/RVRTGVy4VDarj7x5LrKpRr1PnSpIL0Hzjb2mn5Gww2ot vm6QCnZQVuA9sPjgPoimERnsK2QuYS3dd9O4eCu/733gJvXLBpnaFtXisdanQfZ7Q9kE 1lK/GA6GctumKzDaUUhq6fQLvcSVdK0wMUnHT/XyMRh/jUh9V5GoN7qqvoSFixFhf7+g pCZEbpUDBpDh6dng2yLZ9G0RAR0OG4qFgqJXzP2XpqPmx2f54odwk/VtOvi3LU0wuCNi 2FBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Yp3b9KmI; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a6566c5000000b005638d4f21a8si8997556pgw.855.2023.07.25.07.33.22; Tue, 25 Jul 2023 07:33:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Yp3b9KmI; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232238AbjGYOcs (ORCPT + 58 others); Tue, 25 Jul 2023 10:32:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232741AbjGYOcp (ORCPT ); Tue, 25 Jul 2023 10:32:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8596510DC; Tue, 25 Jul 2023 07:32:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9A9E96177C; Tue, 25 Jul 2023 14:31:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8B5AC433C8; Tue, 25 Jul 2023 14:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690295512; bh=YosH8SfwlkT1e2RagDaWUEiwWFWG2YRJM54/ZBoEHII=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Yp3b9KmI+WelkGJ0KwcyxpF4R0528rZa1cU10k5eOrsd7dQmuv9CnX0fr4yTrHrlt oZbEBPbOeO8FHGrfOkAqSsJQycFy16x3grA1+mecKlLvtdFU6fQkAjmwj5qZLF8e1F 61Lity2LHSQU1Ryei5IdcIBy9Oc95LBEyvMm66xznm6i1pyKvGqrO0a0nA8N++nmj5 SGDOfc5itLG+sHKEuVATd05vG8RcS9HE0NgIf7Z8BrS6vsJ2Z/TabX+iR6Pe5Jx8uT Nq+0KJKspf4/K763C/Kw7A37vu5/AKLwlK7/S7shfFRld9tdq6V3ngzZIlI5DrM98n YnEAwlo7d736g== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v4] wifi: ath9k: fix printk specifier From: Kalle Valo In-Reply-To: <20230723040403.296723-1-dzm91@hust.edu.cn> References: <20230723040403.296723-1-dzm91@hust.edu.cn> To: Dongliang Mu Cc: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Dongliang Mu , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169029550891.3210124.11487387565117969944.kvalo@kernel.org> Date: Tue, 25 Jul 2023 14:31:50 +0000 (UTC) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dongliang Mu wrote: > Smatch reports: > > ath_pci_probe() warn: argument 4 to %lx specifier is cast from pointer > ath_ahb_probe() warn: argument 4 to %lx specifier is cast from pointer > > Fix it by modifying %lx to %p in the printk format string. > > Note that with this change, the pointer address will be printed as a > hashed value by default. This is appropriate because the kernel > should not leak kernel pointers to user space in an informational > message. If someone wants to see the real address for debugging > purposes, this can be achieved with the no_hash_pointers kernel option. > > Signed-off-by: Dongliang Mu > Acked-by: Toke Høiland-Jørgensen > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 061115fbfb2c wifi: ath9k: fix printk specifier -- https://patchwork.kernel.org/project/linux-wireless/patch/20230723040403.296723-1-dzm91@hust.edu.cn/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches