Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d8f5991d-d3cd-4f15-ada7-53d3b93e07e3@yandex.ru>
Date:   Tue, 25 Jul 2023 18:50:30 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>, Ajay.Kathat@microchip.com
Cc:     Amisha.Patel@microchip.com, linux-wireless@vger.kernel.org
References: <20230713082616.112160-1-dmantipov@yandex.ru>
 <df4db7fe-b51d-5eba-dd9d-527753903eac@microchip.com>
 <87r0ow111o.fsf@kernel.org>
From:   Dmitry Antipov <dmantipov@yandex.ru>
Subject: Re: [PATCH] wifi: wilc1000: simplify TX callback functions
In-Reply-To: <87r0ow111o.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/25/23 18:08, Kalle Valo wrote:

> There was no response from Dmitry but I suspect this was not tested on a
> real device. Submitting patches like this without any real testing is a
> bad idea as the risk of regressions is high. Please _always_ test
> patches on a real device. Only exception are trivial patches which can
> be easily reviewed.

Note there was a 2nd version of this, see
https://patchwork.kernel.org/project/linux-wireless/patch/20230717084400.57882-1-dmantipov@yandex.ru.
I'm not insisting on accepting this patch as is, but hope that developers at
Microchip should be capable to consider it for their next major driver update.

Dmitry