Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <54dc7722-0335-e585-56fd-c01318c52ed4@quicinc.com>
Date:   Tue, 25 Jul 2023 15:44:13 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
From:   Aloka Dixit <quic_alokad@quicinc.com>
Subject: Re: [PATCH v4 06/11] wifi: ath12k: prepare EHT peer assoc parameters
To:     Wen Gong <quic_wgong@quicinc.com>, <ath12k@lists.infradead.org>,
        <linux-wireless@vger.kernel.org>
CC:     Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
References: <20230602235820.23912-1-quic_alokad@quicinc.com>
 <20230602235820.23912-7-quic_alokad@quicinc.com>
 <f4515520-1d3b-1b07-6ddd-ae269c12a91f@quicinc.com>
 <cdfbb85a-f3be-8cdc-7117-7550d3808a13@quicinc.com>
 <f9f53552-4823-c841-866a-77057bef0b11@quicinc.com>
Content-Language: en-US
In-Reply-To: <f9f53552-4823-c841-866a-77057bef0b11@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/25/2023 3:07 AM, Wen Gong wrote:
> 
> For station mode of ath12k, the eht_cap->eht_mcs_nss_supp is from the IE 
> "Supported
> EHT-MCS and NSS Set" in assoc resp of AP in function 
> ieee80211_eht_cap_ie_to_sta_eht_cap().
> Now it is "EHT-MCS Map (BW <= 80MHz): 0x222222" for the AP(11BE-EHT mode 
> for 20 MHz
> bandwidth on 6 GHz band) in my test as below IEs.
> 
> The field only_20mhz and field _80 are union in struct 
> ieee80211_eht_mcs_nss_supp, the
> value of field _80 is 0x222222 for this AP, then the value of field 
> only_20mhz is like this:
> rx_tx_mcs7_max_nss=0x22,
> rx_tx_mcs9_max_nss=0x22,
> rx_tx_mcs11_max_nss=0x22,
> rx_tx_mcs13_max_nss=0.
> 
> Then ath12k_mac_set_eht_mcs() will get value 0 fro mcs13 because it used 
> the field only_20mhz
> passed by ath12k_peer_assoc_h_eht().
> 

Understood, I fixed the default case to check for the he_cap field for 
the bandwidth support instead of peer_phymode in v5.