Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a5d91458-d494-6000-7607-0f17c4461b6e@intel.com>
Date:   Wed, 26 Jul 2023 12:48:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH net-next v2] page_pool: split types and declarations from
 page_pool.h
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>,
        Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        Yunsheng Lin <linyunsheng@huawei.com>
CC:     <davem@davemloft.net>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Wei Fang <wei.fang@nxp.com>,
        Shenwei Wang <shenwei.wang@nxp.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Geetha sowjanya <gakula@marvell.com>,
        "Subbaraya Sundeep" <sbhatta@marvell.com>,
        hariprasad <hkelam@marvell.com>,
        "Saeed Mahameed" <saeedm@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        "Alexei Starovoitov" <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "Jesper Dangaard Brouer" <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Felix Fietkau <nbd@nbd.name>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        "Ryder Lee" <ryder.lee@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        "Sean Wang" <sean.wang@mediatek.com>,
        Kalle Valo <kvalo@kernel.org>,
        "Matthias Brugger" <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        <linux-rdma@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-wireless@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>
References: <20230725131258.31306-1-linyunsheng@huawei.com>
 <ZL/fVF7WetuLgB0l@hera> <20230725141223.19c1c34c@kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230725141223.19c1c34c@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2VLRHRGZnFlOStoUmFxL0JIbUs4MGttdnlyWVZHaXp4ZDh5UEgvWUJNZDln?=
 =?utf-8?B?WEc4cG5heFVzK21FYWhOUzJLY3NFeXhpU0ZEaXlza2xuNnUyZDk0RjFmMmxs?=
 =?utf-8?B?ZEw0Yk1MbURKUTU2VDRMZmZNTDR6emNDaUczY0s5U2NsTitDSzgrNDdZTktL?=
 =?utf-8?B?UjVLNU0rdUlYdUZjU1hZRWRrcFZKWXlUUXZvVDVsUjlmWHo1OWw1UGZJU3Nz?=
 =?utf-8?B?Y0YzczlUaEhRYTdpT3lnNzlKT1JTLzVmSFRqRzlZalQ0OTM5WVZBVmV5WFRj?=
 =?utf-8?B?aUQ5bVMwZm1ZVHFVRUpRT2hHQWRWdTBWTGlNYTZRK2ZIaTNUMEthUkRWV3JR?=
 =?utf-8?B?RUdFc2VRZ3Y0YkpzNlJtdHg3L0pUMDJnUDJmU2hhOU0vK3h3QVQ1SEVHcUtP?=
 =?utf-8?B?RVVhRERxZVFvYVhNVlVGSlNhYkVyTFlKNFQvQnh0OGl5YnZqS0VydEVFcGds?=
 =?utf-8?B?bkF6bHVSdm1icjdxQVNJTkZ3Y1lXTWE2eFhDenV1N2ppM3RvZU1GalhndVA4?=
 =?utf-8?B?L2Z1WXJOdU52M0JhUXVNYTJvVUJobEtGVStNa3RkZ2xMa1VxOEtCeDBlMGN0?=
 =?utf-8?B?UTErSVo2MDdzbHNoZTczcE11bHNKbFU5M2xjTDdQRDBBQkZ3NEQ4YzhXL2x0?=
 =?utf-8?B?alorL0cxaXFLaXVId2MzTDVadDhaZHVsSHlrckprejkvL3hJWjFQSWtMRUNx?=
 =?utf-8?B?KzJqaDJuMkNVNThHaitoUFJ2TGFEMHdTYm1HTDAyZTJtWDM5cUg5aUZPQWVt?=
 =?utf-8?B?UDdqRmd3elF6TG1KQnNXRTQzb3N5aWptc3FYMkFYckthaHArM3lYZjhJTG03?=
 =?utf-8?B?aW9tVXZ0cVZrNG5aeEVjeHVIUmFuUlNRQUwxRE1IenRnTWJCbEowVDhKNGd0?=
 =?utf-8?B?czROTWxsQ1hCaEl3MHNEZE5LUWZPRnZNbkNQS1M3SC85dEs5bjNGU1ZwNGNQ?=
 =?utf-8?B?VjgySWtudnk2c1AvYTQ3ekxjQkZYc05HOUJYQ1lldGZDOW03cmt5Y09NcEFR?=
 =?utf-8?B?bW9jM0xHRTd4RGFBVnFLNHV6ZDJNUDBQSys2SmRRL0lXV1FPM1JQVWt0VWtY?=
 =?utf-8?B?Nk1KQTBMdHFOSC9paFRUbnVQUzRqWjI0UDhHS0tUVUxUa0sxdFpFU0JoOTU1?=
 =?utf-8?B?N3dGbU1VenlFY09lRkVRNWw5UTJlTFVzRG1TOVlJSGx6VXE4RVpnMlVSMGVt?=
 =?utf-8?B?L0FHKzZuc1JmaE1UZzhpVlZheTRyejIxekdzT3VCNnlWbFIrcEhTdHR1Q00x?=
 =?utf-8?B?VDZKdTdZZ2hsWWl6RTR3Q1JOc0VCczU1QzJOamJRRWJ3VkxjdWpENXVNTlhk?=
 =?utf-8?B?NmR2T3EzSnNONWRORW9uR2JVZVNHclRJL1NuWlBrQlFscVhubHE2bXFQNXNm?=
 =?utf-8?B?ZEpwaGZRNm43bjlOcjZ6NmFhcEhPOE8zYXhkbWNYdWpsSTl2YlFjdFBJNWFV?=
 =?utf-8?B?RW40MWZlVEJPaXdDNllmN1BQbnZCZ29UR0dHZW90UmxyaTlsVGFzcERsY1FX?=
 =?utf-8?B?OVhPTFdoOEJOMzNtL3RhRGVjLzNpS3hMa2hSRm1pNzVpS3gwcDNLazFaNDB6?=
 =?utf-8?B?NTIrZmhjbUF3THlKVWdQb3VXdDBWNjNPckR3cTJJRjhaazFkdkdJd3pWM2NZ?=
 =?utf-8?B?QVpDNFhWUjhmSW9BeFZTamVkQUVkWUNRMVNMQ1FnRFFoOGVCK0hNbytzbVdU?=
 =?utf-8?B?SkphbkpXeXd6dTkwdTdKeUdoRkkrV1puUDUzc1VFTktnRFg0VnBzODlYRlI4?=
 =?utf-8?B?U2VZMkhaelRKK1o5SnFxQ2pSRUhWMUxJc2lKeWIxMHBxR2E5UmhiakM4K2t2?=
 =?utf-8?B?ZW9PaHRxMjRXWVczZUtzTFpIZGh5TTJzYnN0dldobThNbzdsYkh1MmNvTUZQ?=
 =?utf-8?B?dG10enJCNWlmNjUzcE0ybUozN3VIbmxFbnBYNjZ3TzZEMGM5c0hVdVU0WXMz?=
 =?utf-8?B?SWJZWWg3S05SUWpuTDgyYSsrYkhoTVRXM0o1MTFzME4zb2MxOGRqa1ArMjVI?=
 =?utf-8?B?R0JZVUkzQlROVi9BK1pzdWVTUXVwTFRJbUs2bnVmeUdNUGE0YW9rTncxV0x4?=
 =?utf-8?B?alp3Q0hPOW9mM0dneFRXRzN6eCs0SEFDUzlHcW04clRYUW0rbHFUZW9LeE1n?=
 =?utf-8?B?YTNUVDdjVHRiTWMwOXVOYk8yeURVTjNTd1R0OFlYWFFWVjA1elZRcmx5OStW?=
 =?utf-8?B?emc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c92c5e4b-a2dc-4042-40a0-08db8dc5fe64
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 10:49:32.2303
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f2LN6K5kJ/uEYX1Z7ZM3xOg0d7/dp1cqY3whD+1lVgWQa+pWYiBskn1i9yGDo8BNBBQ8wV21Tq5RGhZJ/EPBNTHhF/L4gj3B6hdZpUQZ4lM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6852
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 25 Jul 2023 14:12:23 -0700

> On Tue, 25 Jul 2023 17:42:28 +0300 Ilias Apalodimas wrote:
>> Apologies for the very late replies, I was on long vacation with limited
>> internet access.
>> Yunsheng, since there's been a few mails and I lost track, this is instead of
>> [0] right? If so, I prefer this approach.  It looks ok on a first quick pass,
>> I'll have a closer look later.
>>
>> [0] https://lore.kernel.org/netdev/20230714170853.866018-2-aleksander.lobakin@intel.com/
> 
> 
> I prefer the more systematic approach of creating a separate types.h
> file, so I don't have to keep chasing people or cleaning up the include
> hell myself. I think it should be adopted more widely going forward,
> it's not just about the page pool.

I have this patch reworked to introduce
include/net/page_pool/{types,helpers}.h in my tree, maybe someone could
take a quick look[0] and say if this works while I'm preparing the next
version for sending? Not the most MLish way, I know :s

[0]
https://github.com/alobakin/linux/commit/19741ee072c32eb1d30033cd4fcb236d1c00bfbf

Thanks,
Olek