Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1220619rwb; Wed, 26 Jul 2023 09:11:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlGWgE8zzwc1TVrBEQUMXbVk3pmdt0HeF+hEUZD5COzpX9MoDiZlSfv/y9/fqbeTTvCwEheM X-Received: by 2002:a17:902:cecd:b0:1b0:3d03:4179 with SMTP id d13-20020a170902cecd00b001b03d034179mr3278782plg.6.1690387901637; Wed, 26 Jul 2023 09:11:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690387901; cv=none; d=google.com; s=arc-20160816; b=Odoyl3Jx3biBXzp9/9NJXoWNxZSXPS+ItUdhxU4Zp53v/fdk2qsiMHGD/22bGLLUTH V7iHpwOp/I5sdE+bCFkVtdkfEA7GZJgPcg7ox1+pQzJeKzBy1GPaKRY3SvcvFj5aA0J0 YYxkMe+//voT2nkSYomqH63Igbczgt0lopN+n9oEg/ZvOOuMT5p5pZWieVrZfpLt/HUh XNjDh2LSUWtgh6BYPqdB44M0KUu8av02OakP/wl4ocFeuUbTXX5Ilq/uHtomVgoJueHX 7t0Xu9QApkpWiR0tyl5RhkHmXhDAFofE4RiKAkjEH6jSx+1unh6K8r5e+hPDXg3m31yn VdtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=jKrTQhM5axG9ddKkoKFz/Ghx4nezQCh3rRkmM+39Klo=; fh=u0zoDLWAEbwb+HKDDwXJbhzdQyEwmpX/9MCQ236/Lj8=; b=JdhVIAeviAVOkH755yUJ9/C9al3dFLoQPvdQYKHo1JRvP0ErQ91YrRCjz9mOgXOsxA 4geoenKoOCAsb18sfrQ6xbrE8TvLKSol7mqDecdKT+gJhMgXTvxu4PCL+nvYqaVOT/op TUNPlHSdaf09rMAmVkI+rf3RbTMYsTNC71uFaLcKYehTabWcnCmRVqg8EhYjLseZS+g/ hU19LQuGH/WuH8i4fq9d/WKF7DL0BpxTF2z63lyaXtYML9vymenBTZyB3Se2lPpU2ZHF +SXvcl5749PLkepZkZCHQNwT6gYBtGn5g8PCnSnaghWbWt7OfPToA+YoUiePNxP0hOQ/ sTMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RzpKJzru; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ko16-20020a17090307d000b001b8a60fb314si12167643plb.409.2023.07.26.09.11.33; Wed, 26 Jul 2023 09:11:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RzpKJzru; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234103AbjGZPrr (ORCPT + 58 others); Wed, 26 Jul 2023 11:47:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231176AbjGZPrq (ORCPT ); Wed, 26 Jul 2023 11:47:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42F63193; Wed, 26 Jul 2023 08:47:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D579161B91; Wed, 26 Jul 2023 15:47:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D1C6C433C8; Wed, 26 Jul 2023 15:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690386464; bh=ntzUm32RuTuI9DzAzwAs39wscUDZsYJF5RGGxmCI+/k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RzpKJzruvMIC6e+h2wdEZ8qON1ieukXJk9w17kGJCOFFhOSuDkuhkgAjiLEpp9ifj mrc1myf+Y48t+Jb4jFaAz85JzvoY2huic7EW0fpoQguPpDQPFtrTSV1ghUlipQMaQq 9RNJiikJiqwV0/LpAsTq0sQhSAAZlQseAlot147AlZ0Onm8a8NFL6ujdtNciaRzOBa z3TtnqnGYqS+7OBw1t5LYs2F7ztrg3Fs1v1aujCnJwNfYUL8UG1sEEOx+vGHlbGl1d xNFWTAZVcXM9GzsKbiYWh31EUWCa5tm1DlUx4shA55XFcYDXHbwZorPr1TRaJ9tFpb Nc5fstcERHKZw== Date: Wed, 26 Jul 2023 08:47:42 -0700 From: Jakub Kicinski To: Alexander Lobakin Cc: Ilias Apalodimas , Yunsheng Lin , , , , , Eric Dumazet , Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , Sunil Goutham , Geetha sowjanya , "Subbaraya Sundeep" , hariprasad , "Saeed Mahameed" , Leon Romanovsky , "Alexei Starovoitov" , Daniel Borkmann , "Jesper Dangaard Brouer" , John Fastabend , Felix Fietkau , Lorenzo Bianconi , "Ryder Lee" , Shayne Chen , "Sean Wang" , Kalle Valo , "Matthias Brugger" , AngeloGioacchino Del Regno , , , , , Subject: Re: [PATCH net-next v2] page_pool: split types and declarations from page_pool.h Message-ID: <20230726084742.7dc67c79@kernel.org> In-Reply-To: References: <20230725131258.31306-1-linyunsheng@huawei.com> <20230725141223.19c1c34c@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 26 Jul 2023 12:48:05 +0200 Alexander Lobakin wrote: > > I prefer the more systematic approach of creating a separate types.h > > file, so I don't have to keep chasing people or cleaning up the include > > hell myself. I think it should be adopted more widely going forward, > > it's not just about the page pool. > > I have this patch reworked to introduce > include/net/page_pool/{types,helpers}.h in my tree, maybe someone could > take a quick look[0] and say if this works while I'm preparing the next > version for sending? Not the most MLish way, I know :s > > [0] > https://github.com/alobakin/linux/commit/19741ee072c32eb1d30033cd4fcb236d1c00bfbf LGTM!