Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b23c9ebe-b49b-0c8c-5e20-d02fd4134844@quicinc.com>
Date:   Wed, 26 Jul 2023 11:31:12 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] wifi: ath11k: simplify
 ath11k_mac_validate_vht_he_fixed_rate_settings()
Content-Language: en-US
To:     Dmitry Antipov <dmantipov@yandex.ru>, Kalle Valo <kvalo@kernel.org>
CC:     Ziyang Huang <hzyitc@outlook.com>,
        <linux-wireless@vger.kernel.org>, <ath11k@lists.infradead.org>
References: <20230726092113.78794-1-dmantipov@yandex.ru>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20230726092113.78794-1-dmantipov@yandex.ru>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/26/2023 2:21 AM, Dmitry Antipov wrote:
> In 'ath11k_mac_validate_vht_he_fixed_rate_settings()', 'ar->ab->peers'
> list is not altered so 'list_for_each_entry()' should be safe.
> 
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
>   drivers/net/wireless/ath/ath11k/mac.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> index 8c77ade49437..2aadf2c387b6 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -8255,7 +8255,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b
>   					       const struct cfg80211_bitrate_mask *mask)
>   {
>   	bool he_fixed_rate = false, vht_fixed_rate = false;
> -	struct ath11k_peer *peer, *tmp;
> +	struct ath11k_peer *peer;
>   	const u16 *vht_mcs_mask, *he_mcs_mask;
>   	struct ieee80211_link_sta *deflink;
>   	u8 vht_nss, he_nss;
> @@ -8278,7 +8278,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b
>   
>   	rcu_read_lock();
>   	spin_lock_bh(&ar->ab->base_lock);
> -	list_for_each_entry_safe(peer, tmp, &ar->ab->peers, list) {
> +	list_for_each_entry(peer, &ar->ab->peers, list) {
>   		if (peer->sta) {
>   			deflink = &peer->sta->deflink;
>   

In the future please make sure driver-specific mailing lists are 
included in your patches when they exist in the MAINTAINERS file. Adding 
ath11k@lists.infradead.org