Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Jul 2023 12:22:36 -0700
From:   Brian Norris <briannorris@chromium.org>
To:     Dmitry Antipov <dmantipov@yandex.ru>
Cc:     Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org,
        lvc-project@linuxtesting.org
Subject: Re: [PATCH 2/5] wifi: mwifiex: drop BUG_ON() from TX error handling
Message-ID: <ZMFyfJrDa5jwI6Ep@google.com>
References: <20230726072114.51964-1-dmantipov@yandex.ru>
 <20230726072114.51964-2-dmantipov@yandex.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230726072114.51964-2-dmantipov@yandex.ru>
Precedence: bulk

On Wed, Jul 26, 2023 at 10:20:53AM +0300, Dmitry Antipov wrote:
> Remove 'BUG_ON()' from 'mwifiex_process_sta_txpd()' and
> 'mwifiex_process_uap_txpd()'. In case of insufficient
> headrom, issue warning and return NULL, which should be
> gracefully handled in 'mwifiex_process_tx()'. Also mark
> error handling branches with 'unlikely()' and simplify
> error messages (there is no need to use formatted output
> to print the value which is known to be zero).
> 
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>

You already sent a version of this patch, and I already gave you
feedback:

https://lore.kernel.org/all/ZJ3lyIQy7GPbA9YL@google.com/

You didn't respond to or integrate that feedback.

Brian