Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chaitanya Tata <chaitanya.mgit@gmail.com>
To:     johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: [PATCH] iw: connect: Fix segfault during open authentication
Date:   Thu, 27 Jul 2023 00:52:45 +0530
Message-Id: <20230726192245.100897-1-Chaitanya.Tata@nordicsemi.no>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

The check for remaining arguments is done after decrement effectively
bypassing the non-zero check and causes a segfault with below command:

  "connect <SSID> auth open/shared".

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
---
 connect.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/connect.c b/connect.c
index e5b177f..33e1a5f 100644
--- a/connect.c
+++ b/connect.c
@@ -77,6 +77,9 @@ static int iw_conn(struct nl80211_state *state,
 	if (argc && strcmp(*argv, "key") != 0 && strcmp(*argv, "keys") != 0)
 		return 1;
 
+	if (!argc)
+		return 0;
+
 	argv++;
 	argc--;
 
-- 
2.34.1