Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1966924rwb; Wed, 26 Jul 2023 23:21:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlFh/W8Nz9/K55dlXmZ8FxUlxpTxxuW6vWKkd+HEwG8SyF8/ilirxMpr4K/2PKG60r/pFBLf X-Received: by 2002:a05:6a20:258d:b0:12d:a04c:7e8b with SMTP id k13-20020a056a20258d00b0012da04c7e8bmr4349550pzd.40.1690438886008; Wed, 26 Jul 2023 23:21:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690438885; cv=none; d=google.com; s=arc-20160816; b=GSHVahaa/WskHbdu4PwEOxiQM8xzI9cCunouBGRGPqUWGvdN7yXjjGswdgC3j9ZcYj NViPySGtJhlG9SfRg9Jul3G8Qo69Ubw0LArCEUalZ5c8sRafO5PQbzAdsYN27/S/uF/p tA6i323weRBrxKMnm4d7khmwKrb7Nyb/PfC8UaxJmH+E+kraLZ9S8Gf+4BFC7G/C0lxb UoV2v+1MAuxFgdLN64nUw9/NjiPL/pW7k4BqJrd9aS/ians8iu+rgfHeDKBEJozaZbdX 9BWYgsaFpYVEBXFvlH/ACpHo7T4cjyAWT3QJ0Dx62JjfuYz4q7vmX2KvrnbkQunRAvaz BmBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=j9o7hbkiTS8qp48uNGIbukwcSqC8AoQnzlU7sRixJIk=; fh=MIYVsduzpwjPjD9YlNxlNyO4tI6/rPruV71xVR75wwg=; b=XBCQ97fZrgSI7DGT9rw8JsuXgsCPnDc3rceiCgAO+3r39WtmkVE1esg1XC/l8A8Sbj GHDyqcFwXchJYQcyPfKIHfFRR84hCHto4y/kxoAOCVHgVGEvzdTac88Ey5j3S1brKmpB lIiSU4kRZuQGLqIcKLQgE5jv8Pc76fiYbdkK1NTqZbXMiHMtEuDRDmp28uAg1a0dKqCz LQCZ6E04VamA4qB0Vztk8CpvbWQGZW6wOBHaEep0evwWGoa3HlLMMcZy+nBDyu0Fjuxk vv7fbDKTb0a5HHe/a+OWALOnk4VTD7FAgWYjgc+5dOv00eRlMQmR9gc5xOm7SimQplEe EsJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OZOqhfD8; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l20-20020a63ea54000000b0055be9543340si698222pgk.872.2023.07.26.23.21.14; Wed, 26 Jul 2023 23:21:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OZOqhfD8; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232617AbjG0GNF (ORCPT + 58 others); Thu, 27 Jul 2023 02:13:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232487AbjG0GND (ORCPT ); Thu, 27 Jul 2023 02:13:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C43BB6 for ; Wed, 26 Jul 2023 23:13:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 38FFC61D34 for ; Thu, 27 Jul 2023 06:13:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 965BAC433C8; Thu, 27 Jul 2023 06:13:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690438381; bh=OAvI6XopJNi1Pf1KeGKriGVhqxH7EObNZwlGc2oTbuY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OZOqhfD8zNOLVPJlMCo41bDv4ViHZ3ibINvG8b2uJwFThMZm8GMaxlDkXC5ivd1yr fRnFPt6UylbmGfvkVyE7ScWVuLIR4MMAdP/6L8VmmKIS/MY76+2avyY6JTRMzThHOK ihE1F/9HD2O37/2tFZgmtVjiauWDZALqqwCYNzozFYGtKiAJVHKg924Ii0svy2l50v hAkuwrN2A7z+qZkgfanAOoc1DSWbXqwybWcCAvJ+1xWz1ssDcDhOKjL1Ud8BQjiWil 3/GY/IWy/uET9jcKO82MAuJR7hfbEC8fCwgXQCO8uMuftw2N4GYrnE4WLyL/9kb/eI Sq6JcDZ94u2Sg== From: Kalle Valo To: Jeff Johnson Cc: Aditya Kumar Singh , , Subject: Re: [PATCH] wifi: ath11k: fix band selection for ppdu received in channel 177 of 5 GHz References: <20230726044624.20507-1-quic_adisi@quicinc.com> <8fe1a927-14da-445c-4c48-e3f4b4c324d4@quicinc.com> Date: Thu, 27 Jul 2023 09:12:58 +0300 In-Reply-To: <8fe1a927-14da-445c-4c48-e3f4b4c324d4@quicinc.com> (Jeff Johnson's message of "Wed, 26 Jul 2023 09:54:46 -0700") Message-ID: <87bkfx287p.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jeff Johnson writes: > On 7/25/2023 9:46 PM, Aditya Kumar Singh wrote: >> 5 GHz band channel 177 support was added with the commit >> "wifi: ath11k: add channel 177 into 5 GHz channel list". However, > > I'd use the same syntax here as in the Fixes tag: > e5e94d10c856 ("wifi: ath11k: add channel 177 into 5 GHz channel list") > >> during processing for the received ppdu in ath11k_dp_rx_h_ppdu(), channel >> number is checked only till 173. This leads to driver code checking for >> channel and then fetching the band from it which is extra effort since >> firmware has already given the channel number in the meta deta. > > nit: s/meta deta/metadata/ I can fix these in the pending branch. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches