Received: by 2002:ac8:45c5:0:b0:405:464a:c27a with SMTP id e5csp1272861qto; Thu, 27 Jul 2023 09:30:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlF2YgAt71KrDycsbywQJKG/U2NKU8znIGfWJZ42d7WMIMPntwu+Y2OPBzX1mLqaupxOAVZl X-Received: by 2002:a17:902:d489:b0:1bb:c7bc:ceb8 with SMTP id c9-20020a170902d48900b001bbc7bcceb8mr4221901plg.22.1690475429872; Thu, 27 Jul 2023 09:30:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690475429; cv=none; d=google.com; s=arc-20160816; b=ie82B8g0znUY319VFT1Q2UrSTCLtzfeFZZpQz9zkw87QLGQyKC4uzXo/hXTQ/99FvA VF2s9CjJ9kGXBlF3T9xc/VijBZVpDyX/aXFQ49MKxzPeKUCl2c9RsqsbIP5yCh88G18t at1HcXptaXduUuGVRIA9b3TpT0Rz9jhH6Pyh6+iSd2UM+e1snEQs9d1ofsgIjYtACjXH nanK67WTwYziDh++vx6DfOVFWJYgshQB41io19VIhfRYwkBDONN/zFjR60mI9Q6fAsv9 n1XsMgOat9ZhZAGS3FKObqPEN9mvnSBF4LVLsmMntsE7RO3HIWv6Cjdt+X/bTixckEuj c6yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=GAolxS4IusoeO3YfRXX+XbhFutKgmKfmAwH/RTvZy64=; fh=b5G9apgK6EIr8flZaPUJy5a8QbyeulZPBVMzNgxzqLk=; b=PAeI/Bx5At+l35exowt9qC+SgxkirRlpr65uM/hf3WGx33pp84IH1GF1tIqx4lY6kc kIYQCHIcTlqr8RDb6+0+y/htEnj9a4w9qG744zOfG1LGNlqDf35yPpJ185F/IlN7F6JJ Ya8WhDQd7NKD/ShV8Je8wJOkhrS9RWmDy+N9OLx+Fu4pChmeIS/XS3Dtma6G6ExuyUdh Mce5pLjTI09i2+lOaFTMRnPz4lSogAsFD+MmrMKQHVByQ3/S9VSruHj8ozMLFCne+Ujd A+qawX3KCZHMOizeppvKqm0Dy+WYeOSA6sznlFTFjiaTTMgbyloG1tI9nIWdQSB0nc4q /thw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Fv4thv+X; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u191-20020a6385c8000000b005638355e990si1520664pgd.410.2023.07.27.09.30.21; Thu, 27 Jul 2023 09:30:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Fv4thv+X; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231915AbjG0QN6 (ORCPT + 58 others); Thu, 27 Jul 2023 12:13:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231656AbjG0QN5 (ORCPT ); Thu, 27 Jul 2023 12:13:57 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D19310B for ; Thu, 27 Jul 2023 09:13:56 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-99bdf08860dso119550866b.0 for ; Thu, 27 Jul 2023 09:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1690474434; x=1691079234; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GAolxS4IusoeO3YfRXX+XbhFutKgmKfmAwH/RTvZy64=; b=Fv4thv+XDhRgj/xBVO7Kekb831rjX3/gAux9itwEq9RzbJAi0eYz+l/hY141jb417b aaDpnCCwQscCyjlonjA62RmE7GRXf1XyJeDkbtdUu+/v38vEyHwsJvxhRh0ffVxt6W6o lvmvdzv9q3o5yp8gAM4X9T0RB6wCp19mOP7h0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690474434; x=1691079234; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GAolxS4IusoeO3YfRXX+XbhFutKgmKfmAwH/RTvZy64=; b=BGaIfebFprnidtR+h5ib0AcLYP6r5dfYnV7Vq9C1glZgE4eQSSKVHW7vhW3A4eGUoO KQfobg9hSmeG6TeICzvG51Mtx0FiwvktZjWJUPfFAbyTGY023QRgxz4xjDw1boXIPmYw qKW5UblOCp3tO6fbfdUOF8DuckOCUfzkRg7OQKr6o407bUizK7/iRmE8O1XysU4mVJ01 oBlSHCMsTvGuzYlRcFqEkOhGcKf9gde/KMSxeZAcICo0vmanmrurveyzZvnH0MeRCx3v o0K3RjMIc7vreXeHAwoWB2GDlNRHpxtyEoBZwLT9xKgZrbfljlEakEEZp0Zch1EWcgJV 1XPg== X-Gm-Message-State: ABy/qLafjyH/inKjdFUaeQO6XyPcqplN3DG+X/0E++oMiINk+TFJ6mRV T+eWp43+BCN11+KzoLG/IDNO7Xr3GhAw4iGsOhXxgA== X-Received: by 2002:a17:907:1b0e:b0:978:2b56:d76e with SMTP id mp14-20020a1709071b0e00b009782b56d76emr2682478ejc.12.1690474434592; Thu, 27 Jul 2023 09:13:54 -0700 (PDT) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com. [209.85.218.53]) by smtp.gmail.com with ESMTPSA id s14-20020a1709064d8e00b0099364d9f0e9sm933439eju.102.2023.07.27.09.13.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 09:13:54 -0700 (PDT) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-9891c73e0fbso235840966b.1 for ; Thu, 27 Jul 2023 09:13:53 -0700 (PDT) X-Received: by 2002:a17:906:2d2:b0:989:450:e565 with SMTP id 18-20020a17090602d200b009890450e565mr3176882ejk.23.1690474433484; Thu, 27 Jul 2023 09:13:53 -0700 (PDT) MIME-Version: 1.0 References: <20230723070741.1544662-1-pinkperfect2021@gmail.com> <87ila528c3.fsf@kernel.org> In-Reply-To: <87ila528c3.fsf@kernel.org> From: Brian Norris Date: Thu, 27 Jul 2023 09:13:38 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7] wifi: mwifiex: Fix OOB and integer underflow when rx packets To: Kalle Valo Cc: Polaris Pi , matthewmwang@chromium.org, kuba@kernel.org, linux-wireless@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Jul 26, 2023 at 11:10=E2=80=AFPM Kalle Valo wrot= e: > > Brian Norris writes: > > Reviewed-by: Brian Norris > > I'm nitpicking but now that you (Brian) are a maintainer I would prefer > that you use Acked-by instead of Reviewed-by. Patchwork shows the > statistics (A/R/T in the web ui) and then it's easy for me to see that > the patch is ready to be applied. This is for the future, no need to > change anything here. Argh, I knew that's the recommendation, and I thought I did that here, but obviously not. Thanks for the reminder. I'm sure I'll fix my muscle memory eventually :) Brian