Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH] wifi: wil6210: fix fortify warnings
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230621093711.80118-1-dmantipov@yandex.ru>
References: <20230621093711.80118-1-dmantipov@yandex.ru>
To:     Dmitry Antipov <dmantipov@yandex.ru>
Cc:     Jakub Kicinski <kuba@kernel.org>, linux-wireless@vger.kernel.org,
        Dmitry Antipov <dmantipov@yandex.ru>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <169047437544.3669718.17424986344996292041.kvalo@kernel.org>
Date:   Thu, 27 Jul 2023 16:12:57 +0000 (UTC)
Precedence: bulk

Dmitry Antipov <dmantipov@yandex.ru> wrote:

> When compiling with gcc 13.1 and CONFIG_FORTIFY_SOURCE=y,
> I've noticed the following:
> 
> In function ‘fortify_memcpy_chk’,
>     inlined from ‘wil_rx_crypto_check_edma’ at drivers/net/wireless/ath/wil6210/txrx_edma.c:566:2:
> ./include/linux/fortify-string.h:529:25: warning: call to ‘__read_overflow2_field’
> declared with attribute warning: detected read beyond size of field (2nd parameter);
> maybe use struct_group()? [-Wattribute-warning]
>   529 |                         __read_overflow2_field(q_size_field, size);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> where the compiler complains on:
> 
> const u8 *pn;
> ...
> pn = (u8 *)&st->ext.pn_15_0;
> ...
> memcpy(cc->pn, pn, IEEE80211_GCMP_PN_LEN);
> 
> and:
> 
> In function ‘fortify_memcpy_chk’,
>     inlined from ‘wil_rx_crypto_check’ at drivers/net/wireless/ath/wil6210/txrx.c:684:2:
> ./include/linux/fortify-string.h:529:25: warning: call to ‘__read_overflow2_field’
> declared with attribute warning: detected read beyond size of field (2nd parameter);
> maybe use struct_group()? [-Wattribute-warning]
>   529 |                         __read_overflow2_field(q_size_field, size);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> where the compiler complains on:
> 
> const u8 *pn = (u8 *)&d->mac.pn_15_0;
> ...
> memcpy(cc->pn, pn, IEEE80211_GCMP_PN_LEN);
> 
> In both cases, the fortification logic interprets 'memcpy()' as 6-byte
> overread of 2-byte field 'pn_15_0' of 'struct wil_rx_status_extension'
> and 'pn_15_0' of 'struct vring_rx_mac', respectively. To silence
> these warnings, last two fields of the aforementioned structures
> are grouped using 'struct_group_attr(pn, __packed' quirk.
> 
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

1ad8237e9716 wifi: wil6210: fix fortify warnings

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230621093711.80118-1-dmantipov@yandex.ru/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches