Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <PA4PR04MB9638100B3F21D083F386C6D9D106A@PA4PR04MB9638.eurprd04.prod.outlook.com>
In-Reply-To: <PA4PR04MB9638100B3F21D083F386C6D9D106A@PA4PR04MB9638.eurprd04.prod.outlook.com>
From:   Brian Norris <briannorris@chromium.org>
Date:   Fri, 28 Jul 2023 09:23:01 -0700
Message-ID: <CA+ASDXMx46aLztpKHqtS_Ab_yV_0GvRdWinf4C9o=9zqtTGehQ@mail.gmail.com>
Subject: Re: [PATCH] wifi: mwifiex: added code to support host mlme.
To:     David Lin <yu-hao.lin@nxp.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Sharvari Harisangam <sharvari.harisangam@nxp.com>,
        Pete Hsieh <tsung-hsien.hsieh@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Wait, your company can't afford to have anyone respond to maintainer
mail for years [1], but you can afford to add new features? Crazy.

[1] https://lore.kernel.org/all/87sf9j3wd1.fsf@kernel.org/

On Thu, Jul 27, 2023 at 11:19=E2=80=AFPM David Lin <yu-hao.lin@nxp.com> wro=
te:
>
> 1. For station mode first.
> 2. This feature is a must for WPA3.
> 3. The code is tested with IW416. There is no guarantee for other chips.

^^ That's not a good sign.

> Signed-off-by: David Lin <yu-hao.lin@nxp.com>

>  drivers/net/wireless/marvell/mwifiex/util.c   |  74 ++++
>  14 files changed, 558 insertions(+), 13 deletions(-)

> --- a/drivers/net/wireless/marvell/mwifiex/main.c
> +++ b/drivers/net/wireless/marvell/mwifiex/main.c
> @@ -28,6 +28,10 @@ module_param(driver_mode, ushort, 0);
>  MODULE_PARM_DESC(driver_mode,
>                  "station=3D0x1(default), ap-sta=3D0x3, station-p2p=3D0x5=
, ap-sta-p2p=3D0x7");
>
> +bool host_mlme;
> +module_param(host_mlme, bool, 0);
> +MODULE_PARM_DESC(host_mlme, "Host MLME support enable:1, disable:0");
> +

I hear Kalle doesn't like module parameters like this. They're a cop
out on properly supporting features (also, see your own commit
message). I'd have to dig through the archives to find the latest
advice and rules on this.

Overall, I'm not enthusiastic about this change.

Brian