Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp4431061rwb; Mon, 31 Jul 2023 06:54:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlGUR2s4T3dj3lYr2kx2LGRGK22vxvy2HlAjKqisi2NKYzLX9piaP7H5Yf7mvBX5QSb8OFcC X-Received: by 2002:a17:907:75d3:b0:994:19ed:e92b with SMTP id jl19-20020a17090775d300b0099419ede92bmr6091425ejc.20.1690811645985; Mon, 31 Jul 2023 06:54:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690811645; cv=none; d=google.com; s=arc-20160816; b=dfss4ftZFR9Zq1fy482bqrgWih+5MnAWDmOTNHxf5jt/qBrqxhHeDw/Od3HvFOy2sq HI27ayrXf/Hdz4xqyZZJkLKsPStwLdhX+ZLb1hXuJ7rhV0zJqGH+jER1GKrUxtG9ZCDu paslfE4ijNw8STPr5vd5WBzXAcrzdgpjxAWT23jhiHswpZL6MohvO5jWMg1GO3KgJrwa lYGpt+7BtJvVln8vPuknowSeqtR/6IMbyNs6zuo4g+iOXnUC3Xpysw0dNyYhE/1lSYQb 0zYekK54V85LZNN7voK2r5LqmBT3wcmC/B1jbijclkbR3aYdFy7b0BhLRMsz1LuIlPLJ PKwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=IH7SMZze3utYMvftQj0mT7yLGA+sjq/nHuemyu4/gKg=; fh=eVC4cQL9/MqoMzoyKCmYkd5+vCbVBvwdHegSmbTQBRw=; b=Nh4uZMn7x/Ii4mm0gdmRPTFvOHfCggvweuiw3rWpj2ZEcuerLgAEt/9zXhFJDFVXmd k7nctMfOY9Xv3IUnncIiX/gue21AWdL5m6A7KVcvUeidky/QKW1U3lBz+5oOK+Ogx0f4 yYZ1T2Cx5bXgm+5mUbYQyAlrQ2I72X7HGcDmvJ7oeZ3pgY99kqXN+irr4Q+UX4UmJCke 3PUWVQ2dIP5BzmFs6ymu3W30tURZfPrrfFd8BFo3bsl2mfe0nOcA4a4L7ZAhK8+pO5s1 ytwvE5YY+5l6RjX+RoIfYaOzCbetZO70NZmKP/tGGoRfdkEkDf3VPv2ctu1s+fGBNjb6 2P8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hoILqnxD; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dv22-20020a170906b81600b009920f18a5e9si7364806ejb.728.2023.07.31.06.53.38; Mon, 31 Jul 2023 06:54:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hoILqnxD; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230479AbjGaN1b (ORCPT + 59 others); Mon, 31 Jul 2023 09:27:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232221AbjGaN12 (ORCPT ); Mon, 31 Jul 2023 09:27:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44A0719A1 for ; Mon, 31 Jul 2023 06:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690809960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IH7SMZze3utYMvftQj0mT7yLGA+sjq/nHuemyu4/gKg=; b=hoILqnxDEshXyTT03NKnjt5QCioFHZJSmjMtXqTSNKlJayP4UwG+TwhLDVl9QkocOdBaMP jirLGM5yQArZJ1t9xImsVqMScSCP76YbZwxOSIAmvQvZIdH2VtLLUqaPlZ+klYefs1p0pD xhfKlwr6MFgVNY6gI+3G7bKrm8bio3o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-410-x0swh82JOgm8NNfGY7ReQQ-1; Mon, 31 Jul 2023 09:25:55 -0400 X-MC-Unique: x0swh82JOgm8NNfGY7ReQQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 20DFE81DB6C; Mon, 31 Jul 2023 13:25:55 +0000 (UTC) Received: from localhost.localdomain (unknown [10.22.48.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46D552017DC6; Mon, 31 Jul 2023 13:25:54 +0000 (UTC) Message-ID: <71b912376301abf0cc56ac572a693b4c7adb5660.camel@redhat.com> Subject: Re: [PATCH 1/6] [v2] wifi: libertas: add missing calls to cancel_work_sync() From: Dan Williams To: Dmitry Antipov Cc: Kalle Valo , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org Date: Mon, 31 Jul 2023 08:25:53 -0500 In-Reply-To: <20230725060531.72968-1-dmantipov@yandex.ru> References: <20230725060531.72968-1-dmantipov@yandex.ru> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2023-07-25 at 09:04 +0300, Dmitry Antipov wrote: > Add missing 'cancel_work_sync()' in 'if_sdio_remove()' > and on error handling path in 'if_sdio_probe()'. >=20 > Signed-off-by: Dmitry Antipov For the v2 series: Tested-by: Dan Williams > --- > =C2=A0drivers/net/wireless/marvell/libertas/if_sdio.c | 2 ++ > =C2=A01 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/wireless/marvell/libertas/if_sdio.c > b/drivers/net/wireless/marvell/libertas/if_sdio.c > index a63c5e622ee3..a35b33e84670 100644 > --- a/drivers/net/wireless/marvell/libertas/if_sdio.c > +++ b/drivers/net/wireless/marvell/libertas/if_sdio.c > @@ -1233,6 +1233,7 @@ static int if_sdio_probe(struct sdio_func > *func, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0flush_workqueue(card->wor= kqueue); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0lbs_remove_card(priv); > =C2=A0free: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cancel_work_sync(&card->packet= _worker); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0destroy_workqueue(card->w= orkqueue); > =C2=A0err_queue: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0while (card->packets) { > @@ -1277,6 +1278,7 @@ static void if_sdio_remove(struct sdio_func > *func) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0lbs_stop_card(card->priv)= ; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0lbs_remove_card(card->pri= v); > =C2=A0 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cancel_work_sync(&card->packet= _worker); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0destroy_workqueue(card->w= orkqueue); > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0while (card->packets) {