Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp5504406rwb; Tue, 1 Aug 2023 03:52:07 -0700 (PDT) X-Google-Smtp-Source: APBJJlHz+6WJiqJojPOf+yzpCSK1l7jkATcHqOuU60RkZQyTRqr+8ux8CXf5cnB9veZnCbQY9y3H X-Received: by 2002:a17:90a:940d:b0:268:46fb:df32 with SMTP id r13-20020a17090a940d00b0026846fbdf32mr11567642pjo.34.1690887126895; Tue, 01 Aug 2023 03:52:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690887126; cv=none; d=google.com; s=arc-20160816; b=j2K9krdwbFgLyvUYQ8sYfe24kz36r3HkjMtF+VSp7gH2qrldXq0K7+YIP/pghsNF1g vtdiPaLQNSROcLsHEUncqgjE/tsKOaOaP7zFOx7uzhP600OQWO2cxM+Ehgq4W5TTHG3L EYUO2k6i6xQotD60XNGshJjk2GBfF5V9mDuLGFkeh/Za7i/sbzbsdH8uK5Q3jqGBFjfB J0NevPPC7Wup8OFlGc17KwaFfgiOA/6+RrfR2pi9EhXdVx1hM9QUOW3HqsWWQe5cg6fp qshwemVVfMDAV6ZNT8nQZTPeMCSlJ3vrfstFbQ/qSvZucT3adkzK5IT82NyX15Kk0C53 7aXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=wACNs5CHlqPRj41Mij+c50e6DFxU82/P/qKof30igPI=; fh=yqTojcVfqZtB9hX9ygIqcWDEXa9uFhygRY09KB+gwms=; b=AYsSq3OLuHlByhJKk9SPqewxqpJ82mkQ41dlGQu9N2AzfYDXRQBIwdn1dfjJULLCdd 9C+PF4i91wU7eCCbqa4Ic8hLm2g+bqmF1tIHQAtDZGXRvpOEN7e5xET4Qd0cdoxQSIuN x/ETU7Fgdn5PeX//jc8chgq6hF5XAaQ1xgrlbBYutkv0Fy7nkW3S5uyPp9pXDYlz5mMu 3OhWJJ1LpiXwAdrLkt9pM5qTfD77DR6sdVk3rACJSwXgaefzx9/R+YI62LsbDXLjdTqY vZbmboXhtGnteaG+gwV0b55x+GfZtribhiPCzSTCn8+/Cr+isdvAHZfL0GMS/IEe2xcV LWBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="SZBNNn/j"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id np10-20020a17090b4c4a00b0026815fe629esi1823540pjb.70.2023.08.01.03.51.59; Tue, 01 Aug 2023 03:52:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="SZBNNn/j"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231271AbjHAK0n (ORCPT + 59 others); Tue, 1 Aug 2023 06:26:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233676AbjHAK0S (ORCPT ); Tue, 1 Aug 2023 06:26:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D1115B96 for ; Tue, 1 Aug 2023 03:23:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E79E61521 for ; Tue, 1 Aug 2023 10:23:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB814C433C8; Tue, 1 Aug 2023 10:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690885404; bh=c929dygUnOm1BSbok++ltvpLIUzEv2S+5RUbs/24cKE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SZBNNn/j7jmUXjAWXZ5tNVLUas80puBbv1YOyXZTIIqdLY3gDQDyCZN5zcVg2GU5a GZ0KnfJDBO68CukcGuQaPwVNrY5We4NDrCfpNiCCgL+ly5cZGybUa27+/cGWEJra/e YOnJHOQ6HtgXvcPb9ohpoDA8iRqTnXtsVffKfAqdNhAQQruTxDnHa+sBonwTBS7OyA CP+O7/MnTjcPH0bTHZM+9ns4L6fB5IcME9w6n0oyrXw+nWUPBpu8qQIdnkAtEVHzA0 +URNxwbRCIEZFZnpx/KqS6ldUoJdmlFgaXxu7MvZjuZzJGc/S4W1FRKFSYfOR6i3o1 ACwTWBUiBGMzg== From: Kalle Valo To: Dmitry Antipov Cc: Doug Brown , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH 1/4] wifi: libertas: add missing calls to cancel_work_sync() References: <20230724084457.64995-1-dmantipov@yandex.ru> <87cz0h3d1q.fsf@kernel.org> Date: Tue, 01 Aug 2023 13:23:21 +0300 In-Reply-To: (Dmitry Antipov's message of "Mon, 24 Jul 2023 11:57:12 +0300") Message-ID: <87r0onxdra.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dmitry Antipov writes: > On 7/24/23 11:54, Kalle Valo wrote: > >> How have you tested these patches? >> > > No physical hardware so compile tested only. In that case please always add "Compile tested only" to the commit log. It's important for us to know if a (non-trivial) patch is tested on a real hardware or just with a compiler. Another problem I see that you don't always reply to review comments and that gives an impression that the comments are ignored. Please always try to reply something to the review comments, even if just a simple "ok" or "I don't agree because...". -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches