Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp737779rwo; Wed, 2 Aug 2023 03:29:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlGDd3igOrzAXkElAR/8fYCaIpEPR7nKrtXGbl4tYom2U+Nyu4cEPCHulwvcgRzJDrBQH/xf X-Received: by 2002:a17:907:a079:b0:993:f611:7c97 with SMTP id ia25-20020a170907a07900b00993f6117c97mr6205655ejc.33.1690972155984; Wed, 02 Aug 2023 03:29:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690972155; cv=none; d=google.com; s=arc-20160816; b=gEqML2jtY7GOLVBYdrCUi5zwwJXGlsQY+nw34OIEeWkxotx5DoJD5MjnPoO8jNpHp1 WK30n3wzAk+z9I3u3JSjUUDTljBHVGDy7ofLKSlcJj7DBwr/TGiuBiZWQgtVjtfRuNoQ x4frDI21trWcMwMXkkq12ejIS5tLCweLZgDE21GBkYx/4S74qiqyhOcGnAwguqdjFI6x oQv1le2BeEaoLU7HnIytycke5Pf2mgNjW3QtRa9AN87LahW8iBOfvD5/lp9SHiNUTIvF PhPHSdTgjNNeAMiV+fgKBFXOaQy1xyEATOgLlYtcWSoyxjXEX6j8490mPjFk1dM7U/Ce V8pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=Rs9Nn/d+1sywc3XpAgT7SrWfqlrPYbq0D08KJOIzgGE=; fh=hvDPwM38tocDUNeeeHg22oKSl2EwZzvx0VqMxBjv4kI=; b=zIJUCTjahckpaOmYKbWtMZT9H8SYFoHITq5jAx3Vt+eu/Yv1tLozK6JsIGo4aVO6jb XKm5w4xZusc0mJIl1IIZU2oKrPs3OljMjly5MVSlWjG9kkchLreYCvRCbBJW2fj49vBS mHdJOzx6UmKJgnjq/cPs1TJ+t+9VYfwCHIblq8EPbP4MQFLlWC8FiITdi9kHzR+BIG6C 7LOr/8kfxc8E5yX2VeDZmJOolFxBp6L8lTuccdY3dD9eOvTFWwzhwYlHetnlh7Y7nYSa IqjsHD64EMugWXW5J5dKRdlENruqFTGXafFQpNslBxEMXfU4WFtj3nlruuPu2ftcyac7 lnZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Bz8NfbDC; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a24-20020a170906245800b0099367350a83si9552504ejb.898.2023.08.02.03.29.01; Wed, 02 Aug 2023 03:29:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Bz8NfbDC; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232782AbjHBKOl (ORCPT + 58 others); Wed, 2 Aug 2023 06:14:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232568AbjHBKOj (ORCPT ); Wed, 2 Aug 2023 06:14:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEB2A211B for ; Wed, 2 Aug 2023 03:14:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2EE53618FB for ; Wed, 2 Aug 2023 10:14:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A800AC433C7; Wed, 2 Aug 2023 10:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690971272; bh=bM2hEaWYm+37HjuzLyv/h4gnb3TgGWMG/3HKOXA2F4Y=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Bz8NfbDCz9n6ZxsrmbXl1AnSLHDyoDJEnvZzy9NI2bAkNDw12xvMx0807fZfUTsKp tI30819KeAsozKOZWvzDyK3GnjVCaSBrmEbEfu3TrgkCLCrdmeTpoiwjtVE9Red3HQ rfpzb396FOnKEGMcnOEBGhPScJj47kD5fe0B/jqS1OrJN+3AiDHo9kDKzqz9ohkCZN O/4xLKS77/v1m0/b1rJGCrI0uuecfDUKFTPksPgHAdVIWlhtdr2RQS40Yn//7A+qSl Tk4SML8KfBNH+7JZ5qXn71VnYF6P5Ov3bEKGxHjKIqdtN9JzukwAtTb0K9yusUxfJA 5yNRyc0U9b77Q== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: wifi: mwifiex: fix error recovery in PCIE buffer descriptor management From: Kalle Valo In-Reply-To: <20230731074334.56463-1-dmantipov@yandex.ru> References: <20230731074334.56463-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Brian Norris , linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169097126949.265879.7193434194073843607.kvalo@kernel.org> Date: Wed, 2 Aug 2023 10:14:31 +0000 (UTC) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dmitry Antipov wrote: > Add missing 'kfree_skb()' in 'mwifiex_init_rxq_ring()' and never do > 'kfree(card->rxbd_ring_vbase)' because this area is DMAed and should > be released with 'dma_free_coherent()'. The latter is performed in > 'mwifiex_pcie_delete_rxbd_ring()', which is now called to recover > from possible errors in 'mwifiex_pcie_create_rxbd_ring()'. Likewise > for 'mwifiex_pcie_init_evt_ring()', 'kfree(card->evtbd_ring_vbase)' > 'mwifiex_pcie_delete_evtbd_ring()' and 'mwifiex_pcie_create_rxbd_ring()'. > > Fixes: d930faee141b ("mwifiex: add support for Marvell pcie8766 chipset") > Signed-off-by: Dmitry Antipov > Acked-by: Brian Norris Patch applied to wireless-next.git, thanks. 288c63d5cb46 wifi: mwifiex: fix error recovery in PCIE buffer descriptor management -- https://patchwork.kernel.org/project/linux-wireless/patch/20230731074334.56463-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches