Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp1204240rwo; Wed, 2 Aug 2023 10:10:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlHerM9hz5PGpV5DKvSOwhnp0stQ4ojQBoOS3BdJQuEQtaup9YAhU43Zjq400xNNpokxcp23 X-Received: by 2002:a05:6a20:431c:b0:13e:b58a:e3e4 with SMTP id h28-20020a056a20431c00b0013eb58ae3e4mr4364538pzk.7.1690996203430; Wed, 02 Aug 2023 10:10:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690996203; cv=none; d=google.com; s=arc-20160816; b=vCPQNsZdbuQAB+Rb0aHi0/cXrGKFDAMg3Q1zl2KGAr0rKrr/7raFT/1kYgDFDLkfjj oVxuPRDcrhn0oqlWkNTQwokxmCR5B+JLydwJY0RAt35wJSqO9J6iV0QgYMMFkKxNw2Ym MmNooC8QxRuF81Zse/J97mm/iiwTMBM4vlty//pzB6DGpaq2F2GtIGrEl9M6EjqMUV0f FGq+mZHA4mlVkDueAwxRB4s0uNS0LGmkYrciIE7wW8gzpmYSiaW6ki2n69SclUSESe46 cgbw8DVpLHQfZJ7tI8ARzO+Q5kZ8wglHUoeTl3d0s1BSecdauBr2bBusZb+7QsvrNXmT /+FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=HxzLXOz8kvF5ZP8j38f61s/MGmHJHKUKzhyNQxFNKDc=; fh=ylibOHjZVoRjcus4fpWusyZbCeuRlezp5RqsfwfDtRY=; b=kd2vQlgJOhRGm0uNoeVahx1Pf1XLqZwVDQk1dQohe1snaYuKmRErfGeTkYRogBZ4iV YEhRqqDAAhzjy3JYfayATglYXgrhjENTP9RFxWv2VWfP7Rwtenngyp4z/lFFSfHdurXv zLrNwBlcuHp8onhyZntww7CCt/CaDEdXRQhG8/MeUX/HE8ScFmpOxrGaIHLhT/T2Sd9T G4Du0IJQxmjZZgyUepCPBbbG9FvtIQnxLJI4l0jDWos+wAZ3+TBSjnVPbQqdd0IADpLY aFyd51nU0SiH7dsjZw6Aoui0cHJ01JCZcgAdZMIYMJNE27zGqZspaQdXWwxpb5ghlqhe E+nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ldII4BBk; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u35-20020a634723000000b005600a533c73si7071594pga.851.2023.08.02.10.09.55; Wed, 02 Aug 2023 10:10:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ldII4BBk; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229825AbjHBRAi (ORCPT + 58 others); Wed, 2 Aug 2023 13:00:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbjHBRAh (ORCPT ); Wed, 2 Aug 2023 13:00:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D89E61712 for ; Wed, 2 Aug 2023 10:00:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6CCAB61961 for ; Wed, 2 Aug 2023 17:00:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA56EC433C7; Wed, 2 Aug 2023 17:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690995635; bh=4ck9yYVimHcNVcAHTcJwYDRKebArzZRF+tFOsMwiOio=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=ldII4BBkkxhQxUgzmIwIGVopa4r/yq+UOohCY/RqzjS/yIDEPchrWdIcQ+XWQi2TK FUSuBDXTLog0q/cT1D6yymh5pI6WpcMeRHiAh63V2t42Ta6XOuex49Yphz+kBpotlr WJRHu6oUlnuk/dL8yyElOEptxdJqpv3BM+rNu87tcpvswF1GnG9f8qv0bpvcOAs7H4 4lwDN4AeHvQ9iAUrfqIDVfRuqho1zazs8T+BYBI1T33rRitERChP8ohMkokEnth3Lu 3731hgVPE5/2sLwjG2Oq3I1VrxwAaqiiod6/kc1o54XbIvPfCvEVm3hFQrHE0YUOXp UviLh8X9jmlpg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: ath12k: trigger station disconnect on hardware restart From: Kalle Valo In-Reply-To: <20230714092555.2018-1-quic_wgong@quicinc.com> References: <20230714092555.2018-1-quic_wgong@quicinc.com> To: Wen Gong Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169099563293.463701.1018312535527006346.kvalo@kernel.org> Date: Wed, 2 Aug 2023 17:00:34 +0000 (UTC) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong wrote: > Currently after the hardware restart triggered from the driver, the > station interface connection remains intact, since a disconnect > trigger is not sent to userspace. This can lead to a problem in > targets where the wifi mac sequence is added by the firmware. > > After the target restart, its wifi mac sequence number gets reset to > zero. Hence AP to which our device is connected will receive frames > with a wifi mac sequence number jump to the past, thereby resulting > in the AP dropping all these frames, until the frame arrives with a > wifi mac sequence number which AP was expecting. > > To avoid such frame drops, its better to trigger a station disconnect > upon target hardware restart which can be done with API > ieee80211_reconfig_disconnect exposed to mac80211. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 68c35cc39b41 wifi: ath12k: trigger station disconnect on hardware restart -- https://patchwork.kernel.org/project/linux-wireless/patch/20230714092555.2018-1-quic_wgong@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches