Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp1205737rwo; Wed, 2 Aug 2023 10:11:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlESna7w6AxsxxGU6Nm6A7/wOYVewKmnxq2Lp8CFp8HF2O1EWkdS9oNtd5KlbawqWFWAl2OQ X-Received: by 2002:a05:6a00:80a:b0:684:aa6c:6524 with SMTP id m10-20020a056a00080a00b00684aa6c6524mr17254212pfk.14.1690996272576; Wed, 02 Aug 2023 10:11:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690996272; cv=none; d=google.com; s=arc-20160816; b=CqUY6yEMfiSi+LVrvQQz1P+fqsSs8vr+vQ4Kiygs4/huL0oT64p/ix3DfRCM9TEqKr ouI1b6/RfwzqRI5pwjC7ScMZBWPcJnfsPkFqZsscGdarJCUhxkCfd4I+BXVg7mP6E710 8XcRmKFN46hPHp6xQ1JSTWNG4PjomJ7meQnIwC07dZBm377aCPlIHMvb5J0B46hpJ2WL YToSlmSLKfOHz9HirWsmoYU0EVMIRcmvm00jCat5vjFwxxOlNxqSFAtR9Hu3S+3LasEV ca6ler+Im7YeTwMPrP6MQ31Mkb9Ad3UnkNA6XsJNaiht4Q+FV9Cq94Qj7aRONgU7z/2B GNmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=W6qSjJ56rVqm/Hs8kST0i/jZMWWMNH72m8r/v5azJ70=; fh=ylibOHjZVoRjcus4fpWusyZbCeuRlezp5RqsfwfDtRY=; b=w9EtXHowCwG8CAbjXnRXkDfYv5iffAGezGV7Rp7NhdvKIMedeU/OrrGddRVLIgxGpr 2Cj5R+HE9m440n7iDZhaaUdkBrNxYWOIYZ69fFBNqJ5aEdATg/ZKPPXWUTLyalsoccZI FK4p2plpBY8+cbFfMzbl8F3GtnsOWiftrdcEpgbiUZytc7JC1tqWLMPMRveanONudu6F us0rwocw2UvPm7CLprB0iV58ByXnVAY4m0Rprv8Fouu0cHiFp5qyPk2M40lLT1nzEdJE rcnhLFrlkKR0lXMCmRhRAOtXM1eF+77MD2wLmbI+hEIK08tk2i/Bb+/KKCHjEw3YzsjJ FypQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kny19TAc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw5-20020a056a00450500b006870b9bddbdsi9511481pfb.62.2023.08.02.10.11.04; Wed, 02 Aug 2023 10:11:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kny19TAc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229960AbjHBQy7 (ORCPT + 58 others); Wed, 2 Aug 2023 12:54:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229803AbjHBQyo (ORCPT ); Wed, 2 Aug 2023 12:54:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91695E53 for ; Wed, 2 Aug 2023 09:54:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 25B6F6194E for ; Wed, 2 Aug 2023 16:54:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C002C433C8; Wed, 2 Aug 2023 16:54:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690995270; bh=A2OruOp+lJC1+M5+VpWcfMzRWKAKt+bR0nx1v+/4O/M=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=kny19TAcHybABvRt1Rhy4fqlLq0E3v3v7M4AAFjXHGn9Shag3S1BMy7I9JwhK1vv9 Q4LPmWEzhlU8NignCZieIvNZoBWgHEMoNjVN3CCMk3Ki1HNfhuYRy71ChKggBVrXqe rhZaGKyzkfmzbF5obxpcTCw9amx8NzRirw3VChAtYxLU7KbYHrrCSS71+S7GX74Y5R r83D90lDaa5gDFGc6BI+LfgfdqDaAVDrzs1EFYuVDJnejSpnmLj1ESxDecWXuaSY6v 7YRxv7W0PB9NtqPNPa2rxE1iJ4teSYbkj1gx7cj5dmVI81nhLvZJcnWuJDn45pUes/ nnq5theb2oFow== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath12k: Fix a NULL pointer dereference in ath12k_mac_op_hw_scan() From: Kalle Valo In-Reply-To: <20230726092625.3350-1-quic_wgong@quicinc.com> References: <20230726092625.3350-1-quic_wgong@quicinc.com> To: Wen Gong Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169099526747.463701.13168373572998934165.kvalo@kernel.org> Date: Wed, 2 Aug 2023 16:54:29 +0000 (UTC) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong wrote: > In ath12k_mac_op_hw_scan(), the return value of kzalloc() is directly > used in memcpy(), which may lead to a NULL pointer dereference on > failure of kzalloc(). > > Fix this bug by adding a check of arg.extraie.ptr. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 8ad314da54c6 wifi: ath12k: Fix a NULL pointer dereference in ath12k_mac_op_hw_scan() -- https://patchwork.kernel.org/project/linux-wireless/patch/20230726092625.3350-1-quic_wgong@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches