Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fae803e7-9131-11bb-ad2d-7a61e76dc9ce@huawei.com>
Date:   Fri, 4 Aug 2023 09:19:22 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH -next] ath9k: Remove unnecessary ternary operators
Content-Language: en-US
To:     <toke@toke.dk>, <kvalo@kernel.org>,
        <linux-wireless@vger.kernel.org>
References: <20230731124455.2039184-1-ruanjinjie@huawei.com>
From:   Ruan Jinjie <ruanjinjie@huawei.com>
In-Reply-To: <20230731124455.2039184-1-ruanjinjie@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Ping.

On 2023/7/31 20:44, Ruan Jinjie wrote:
> Ther are a little ternary operators, the true or false judgement
> of which is unnecessary in C language semantics.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
>  drivers/net/wireless/ath/ath9k/eeprom_9287.c  | 3 +--
>  drivers/net/wireless/ath/ath9k/hif_usb.c      | 2 +-
>  drivers/net/wireless/ath/ath9k/htc_drv_main.c | 2 +-
>  3 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/eeprom_9287.c b/drivers/net/wireless/ath/ath9k/eeprom_9287.c
> index 3caa149b1013..fd5312c2a7e3 100644
> --- a/drivers/net/wireless/ath/ath9k/eeprom_9287.c
> +++ b/drivers/net/wireless/ath/ath9k/eeprom_9287.c
> @@ -572,8 +572,7 @@ static void ath9k_hw_set_ar9287_power_per_rate_table(struct ath_hw *ah,
>  	}
>  
>  	for (ctlMode = 0; ctlMode < numCtlModes; ctlMode++) {
> -		bool isHt40CtlMode =
> -			(pCtlMode[ctlMode] == CTL_2GHT40) ? true : false;
> +		bool isHt40CtlMode = pCtlMode[ctlMode] == CTL_2GHT40;
>  
>  		if (isHt40CtlMode)
>  			freq = centers.synth_center;
> diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
> index 27ff1ca2631f..e5414435b141 100644
> --- a/drivers/net/wireless/ath/ath9k/hif_usb.c
> +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
> @@ -1432,7 +1432,7 @@ static void ath9k_hif_usb_disconnect(struct usb_interface *interface)
>  {
>  	struct usb_device *udev = interface_to_usbdev(interface);
>  	struct hif_device_usb *hif_dev = usb_get_intfdata(interface);
> -	bool unplugged = (udev->state == USB_STATE_NOTATTACHED) ? true : false;
> +	bool unplugged = udev->state == USB_STATE_NOTATTACHED;
>  
>  	if (!hif_dev)
>  		return;
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> index 51766de5ec3b..44e02cfe2438 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> @@ -719,7 +719,7 @@ static int ath9k_htc_tx_aggr_oper(struct ath9k_htc_priv *priv,
>  
>  	aggr.sta_index = ista->index;
>  	aggr.tidno = tid & 0xf;
> -	aggr.aggr_enable = (action == IEEE80211_AMPDU_TX_START) ? true : false;
> +	aggr.aggr_enable = action == IEEE80211_AMPDU_TX_START;
>  
>  	WMI_CMD_BUF(WMI_TX_AGGR_ENABLE_CMDID, &aggr);
>  	if (ret)