Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp3414524rwo; Fri, 4 Aug 2023 04:45:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG47iA7Lk4XcdMv9KqmD9erfBrvvIhrezkJs2C1kxAXer8XPo1ruueLPfDG8kxR+8BYgk+k X-Received: by 2002:aa7:db52:0:b0:522:36f0:f1a3 with SMTP id n18-20020aa7db52000000b0052236f0f1a3mr1291744edt.10.1691149512501; Fri, 04 Aug 2023 04:45:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691149512; cv=none; d=google.com; s=arc-20160816; b=Lyg+FnUSA0V1kfKwvIJ22AE7lxP/8HN5b2tdA3Xbq4WADoAZ86bLkAQHPy3LxsYqPF 8ADnKlZgExT6PDra8uVctiFRggMZKteFzP1mOoI3LM7ycUSm+hegk9cOb69Bh35WBvNS 5WgvDNxioISV9HXbFP6HfavnkMb7Cwu+jmd3dUZxEPyE7Y3jMizjV1lZrIHVXT7He1Sz POOqv9xULTU55xEXfGpT5xdn6/PII+GKDsWcXUW96byidNYpDEdZmneWWkcB0wbkKZCr zXRViHVgYMVqOGcfrJRI/KOBBt+xyDnJHeQPdeWgV7yV0r0f2TMEAlVoYPkCQy5q5mUo uvmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=BGz3azugxbuPHvZCG03z6DCbpUTWLAuWaJu9B01OMAo=; fh=ZCFNeCusLWm9262MSDuiAMocSJXE2gGO65f4ZR3D5Ic=; b=ZOxAcjhBV9P7Gjs8CcyPfahEpdOKQ0hyQ54jgkqYGsLd3fGUrnC3DiUvwu7abgOZDu ATtUXAWcmBeh5FNr/V4Uqhid9F2EUYCc9hS2DsZFm7N7jU+sKj9PrHuF186FnMJ9Ljb2 DMkPr9to2cFM0VmZlZZfV6XIPVmaHWmhkT1R+Rz1kZnEoo+rgttR6RzIRcxSibdY3G+x 36jEbD/F0uX9NMhOnl6KEKtkExxubeLxJyLXP9mIf/XI1IXbzbZl4TIRQ7JpwRc5oBrt E8zDuJZiOACW+IwYXeKhh5L82YUwiUyzuCJqpWEqRCm/a6RRmzcNA/EUpwvWI6kBP5u0 s3wg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r14-20020aa7d14e000000b00522584bb598si1470256edo.135.2023.08.04.04.44.52; Fri, 04 Aug 2023 04:45:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229846AbjHDLMJ (ORCPT + 56 others); Fri, 4 Aug 2023 07:12:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229877AbjHDLMI (ORCPT ); Fri, 4 Aug 2023 07:12:08 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 624AAEA; Fri, 4 Aug 2023 04:12:07 -0700 (PDT) X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 374AonmqF007376, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 374AonmqF007376 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=FAIL); Fri, 4 Aug 2023 18:50:49 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Fri, 4 Aug 2023 18:50:50 +0800 Received: from [127.0.1.1] (172.16.16.139) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Fri, 4 Aug 2023 18:50:49 +0800 From: Ping-Ke Shih To: CC: , , Subject: [PATCH] wifi: rtw89: fix 8852AE disconnection caused by RX full flags Date: Fri, 4 Aug 2023 18:50:02 +0800 Message-ID: <20230804105002.5781-1-pkshih@realtek.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [172.16.16.139] X-ClientProxiedBy: RTEXMBS02.realtek.com.tw (172.21.6.95) To RTEXMBS04.realtek.com.tw (172.21.6.97) X-KSE-ServerInfo: RTEXMBS04.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org RX full flags are raised if certain types of RX FIFO are full, and then drop all following MSDU of APMDU. In order to resume to receive MSDU when RX FIFO becomes available, we clear the regitster bits by the commit a0d99ebb3ecd ("wifi: rtw89: initialize DMA of CMAC"). But, 8852AE needs more settings to support this. To quickly fix disconnection problem, revert the behavior as before. Fixes: a0d99ebb3ecd ("wifi: rtw89: initialize DMA of CMAC") Reported-by: Damian B Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217710 Cc: Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw89/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c index 1efa4da3cebc..cebefa3b1db3 100644 --- a/drivers/net/wireless/realtek/rtw89/mac.c +++ b/drivers/net/wireless/realtek/rtw89/mac.c @@ -2524,7 +2524,7 @@ static int cmac_dma_init(struct rtw89_dev *rtwdev, u8 mac_idx) u32 reg; int ret; - if (chip_id != RTL8852A && chip_id != RTL8852B) + if (chip_id != RTL8852B) return 0; ret = rtw89_mac_check_mac_en(rtwdev, mac_idx, RTW89_CMAC_SEL); -- 2.25.1