Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] wifi: iw_handler.h: Remove unused declaration
 dev_get_wireless_info()
To:     Simon Horman <horms@kernel.org>
CC:     <johannes@sipsolutions.net>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>
References: <20230803134248.42652-1-yuehaibing@huawei.com>
 <ZMvr2lNVTPLqs8Nq@kernel.org>
From:   Yue Haibing <yuehaibing@huawei.com>
Message-ID: <57db587d-c845-5ff5-7b6d-c4196a105fb4@huawei.com>
Date:   Fri, 4 Aug 2023 21:21:01 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <ZMvr2lNVTPLqs8Nq@kernel.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/8/4 2:03, Simon Horman wrote:
> On Thu, Aug 03, 2023 at 09:42:48PM +0800, Yue Haibing wrote:
>> Commit 556829657397 ("[NL80211]: add netlink interface to cfg80211")
>> declared but never implemented this, remove it.
>>
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>> ---
>>  include/net/iw_handler.h | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h
>> index d2ea5863eedc..99f46f521aa7 100644
>> --- a/include/net/iw_handler.h
>> +++ b/include/net/iw_handler.h
>> @@ -432,9 +432,6 @@ struct iw_public_data {
>>  
>>  /* First : function strictly used inside the kernel */
>>  
> 
> Hi Yue Haibing,
> 
> I think you can remove the comment above and blank line below it too.
> 
>> -/* Handle /proc/net/wireless, called in net/code/dev.c */
>> -int dev_get_wireless_info(char *buffer, char **start, off_t offset, int length);
>> -
>>  /* Second : functions that may be called by driver modules */
> 
> And work this into the comment above the to be deleted 'First :' comment.
> Something like this:

Thanks, will rework.
> 
> /*
>  * Functions part of the Wireless Extensions (defined in net/core/wireless.c).
>  * These may be called by driver modules.
>  */ 
> 
>>  
>>  /* Send a single event to user space */
>> -- 
>> 2.34.1
>>
>>
> .
>