Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 6 Aug 2023 21:46:01 +0200
From:   Simon Horman <horms@kernel.org>
To:     Yue Haibing <yuehaibing@huawei.com>
Cc:     Simon Horman <horms@kernel.org>, johannes@sipsolutions.net,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH v2] wifi: iw_handler.h: Remove unused declaration
 dev_get_wireless_info()
Message-ID: <ZM/4eUvFj7CnIUJi@vergenet.net>
References: <20230804133617.43564-1-yuehaibing@huawei.com>
 <ZM3/+pY9Fovc5AC9@vergenet.net>
 <e19091f1-497a-b673-9010-2e0a48d5942e@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e19091f1-497a-b673-9010-2e0a48d5942e@huawei.com>
Precedence: bulk

On Sat, Aug 05, 2023 at 04:24:04PM +0800, Yue Haibing wrote:
> On 2023/8/5 15:53, Simon Horman wrote:
> > On Fri, Aug 04, 2023 at 09:36:17PM +0800, Yue Haibing wrote:
> >> Commit 556829657397 ("[NL80211]: add netlink interface to cfg80211")
> >> declared but never implemented this, remove it.
> >>
> >> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> >> ---
> >> v2: fix comment
> >> ---
> >>  include/net/iw_handler.h | 11 ++---------
> >>  1 file changed, 2 insertions(+), 9 deletions(-)
> >>
> >> diff --git a/include/net/iw_handler.h b/include/net/iw_handler.h
> >> index d2ea5863eedc..b2cf243ebe44 100644
> >> --- a/include/net/iw_handler.h
> >> +++ b/include/net/iw_handler.h
> >> @@ -426,17 +426,10 @@ struct iw_public_data {
> >>  
> >>  /**************************** PROTOTYPES ****************************/
> >>  /*
> >> - * Functions part of the Wireless Extensions (defined in net/core/wireless.c).
> >> - * Those may be called only within the kernel.
> >> + * Functions part of the Wireless Extensions (defined in net/wireless/wext-core.c).
> > 
> > Can I confirm that the wireless.c -> wext-core.c change is intentional?
> > It doesn't seem strictly related to the patch description.
> 
> Commit 11433ee450eb ("[WEXT]: Move to net/wireless") rename  net/core/wireless.c to net/wireless/wext.c
> then commit 3d23e349d807 ("wext: refactor") refactor wext.c to wext-core.c
> The wext functions now sits in net/wireless/wext-core.c
> This may need describe in patch description.

Thanks, I think that would be best

...