Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <897b61ea-36d2-1ab4-9c60-9bdfd2d9cad7@quicinc.com>
Date:   Mon, 7 Aug 2023 12:53:10 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] wifi: ath11k: fix boot failure with one MSI vector
To:     Baochen Qiang <quic_bqiang@quicinc.com>,
        Kalle Valo <kvalo@kernel.org>
CC:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
References: <20230601033840.2997-1-quic_bqiang@quicinc.com>
 <87fs70hlel.fsf@kernel.org>
 <545cc8e8-481d-85b2-5692-43580936b48d@quicinc.com>
Content-Language: en-US
From:   Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
In-Reply-To: <545cc8e8-481d-85b2-5692-43580936b48d@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/7/2023 12:44 PM, Baochen Qiang wrote:
> 
> On 6/9/2023 8:26 PM, Kalle Valo wrote:
>> Baochen Qiang <quic_bqiang@quicinc.com> writes:
>>
>>> Commit 5b32b6dd96633 ("ath11k: Remove core PCI references from
>>> PCI common code") breaks with one MSI vector because it moves
>>> affinity setting after IRQ request, see below log:
>>>
>>> [ 1417.278835] ath11k_pci 0000:02:00.0: failed to receive control 
>>> response completion, polling..
>>> [ 1418.302829] ath11k_pci 0000:02:00.0: Service connect timeout
>>> [ 1418.302833] ath11k_pci 0000:02:00.0: failed to connect to HTT: -110
>>> [ 1418.303669] ath11k_pci 0000:02:00.0: failed to start core: -110
>>>
>>> The detail is, if do affinity request after IRQ activated,
>>> which is done in request_irq(), kernel caches that request and
>>> returns success directly. Later when a subsequent MHI interrupt is
>>> fired, kernel will do the real affinity setting work, as a result,
>>> changs the MSI vector. However at that time host has configured
>>> old vector to hardware, so host never receives CE or DP interrupts.
>>>
>>> Fix it by setting affinity before registering MHI controller
>>> where host is, for the first time, doing IRQ request.
>>>
>>> Tested-on: WCN6855 hw2.0 PCI 
>>> WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>>>
>>> Fixes: 5b32b6dd9663 ("ath11k: Remove core PCI references from PCI 
>>> common code")
>>> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
>> I'm worried if this breaks WCN6750 support. Manikanta, would able to
>> test this patch on WCN6750 and let us know if breaks anything?
> Hi Manikanta, could you help test this patch on WCN6750?

Sure, we will test and update this here.

Thanks,
Manikanta