Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <84f63b86-6d7d-9547-d4b7-d66a44b23c30@intel.com>
Date:   Mon, 7 Aug 2023 10:35:52 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH -next 2/6] ethernet/intel: Remove unnecessary ternary
 operators
Content-Language: en-US
To:     Ruan Jinjie <ruanjinjie@huawei.com>, <sgoutham@marvell.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <jesse.brandeburg@intel.com>,
        <anthony.l.nguyen@intel.com>, <tariqt@nvidia.com>,
        <s.shtylyov@omp.ru>, <aspriel@gmail.com>,
        <franky.lin@broadcom.com>, <hante.meuleman@broadcom.com>,
        <kvalo@kernel.org>, <richardcochran@gmail.com>,
        <yoshihiro.shimoda.uh@renesas.com>,
        <u.kleine-koenig@pengutronix.de>, <mkl@pengutronix.de>,
        <lee@kernel.org>, <set_pte_at@outlook.com>,
        <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <linux-rdma@vger.kernel.org>,
        <linux-renesas-soc@vger.kernel.org>,
        <linux-wireless@vger.kernel.org>,
        <brcm80211-dev-list.pdl@broadcom.com>,
        <SHA-cyfmac-dev-list@infineon.com>
References: <20230804035346.2879318-1-ruanjinjie@huawei.com>
 <20230804035346.2879318-3-ruanjinjie@huawei.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20230804035346.2879318-3-ruanjinjie@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjFhcElwUEdtdk9VWkpWaTBtbnhqRlRlTy9WOUN5NGgrRGFWQ2tGWDZhMVZR?=
 =?utf-8?B?bTRVcnpYS1dmbWFSTUl4MVVTRjdPeXlQaThNN3cwL1BMc2VCRXI2OUszakhv?=
 =?utf-8?B?cE9BN2xZV0Z0KzRHd3VoblQ2aWtleDAzSDF0VG8wdGVrQllCMUpaS1VXNHhP?=
 =?utf-8?B?Z1gra1NOVnBLeDVHdXB6YkhFZWlmMWtMY3pRZjNTV1J5YnZoUFBoaGNjYldY?=
 =?utf-8?B?S0FFL1pENWFvTVVJanVmNXh6bGp6RndNME5Ba0pHK2J6YVMvTDRCVHhmOU5s?=
 =?utf-8?B?NXZqRkRoN1Y3bng4UHo0aTZvbCttc2NGN2kvWkVRdElWZkp5U3kwQk1VRlp6?=
 =?utf-8?B?QVpMNzhMdUVXWFR1MXI1bGNUaXBPZHMvTy9zc0lBeHdlalZQVXNPaXdvNEFo?=
 =?utf-8?B?bUNjSjV1aUJFSnZQRS80am9yY1M5Y2JMa2lTaUIzcnlTQWdxeFNWUUJNK29o?=
 =?utf-8?B?TFVkcFpmTVlaNDd6T2RBZkRKL0l5dmduNjRaNG94WGZLeDVQZVZBMEp6cHZI?=
 =?utf-8?B?bUZ1UEdaS0l6S3RjOGE4cFdkc3EwMDFnaVlFMGtmY3BkZ01LSkhoNlhPdmZm?=
 =?utf-8?B?RFI5RkFXODBQd0Y1Ykc3Q3VBWForVFdwM2R4aUZlRTkwbnEvRUQzZ0Y4U2VQ?=
 =?utf-8?B?U2d3b3drNmpibGdOc0VCbHlzOGZ2ejNNRDhNd01Gc1ZQclRLN1F4andIM2Za?=
 =?utf-8?B?TzRRcGJuSE1uOW0wVEZWVjlYQ0JnQ0J6bS9sd0ZmM3ZoMWVMeUdZSmt5ZVo5?=
 =?utf-8?B?TFhLZFNPNHUyOGhtZktiblBTR0dkSktxTVpTWHhyd0xRMGFWZ1ZyVTJnUWN6?=
 =?utf-8?B?TGw1UHRMb3NmQm5hU005L2Z4UElmMHA1QXBySHdoRWV0K0RyVmsvVldaaldk?=
 =?utf-8?B?NkUvZHdsOFYrY2lUblBQN2xWTlBORmtiUGJsN3NHVUlIUllWTnA4UVRZWFox?=
 =?utf-8?B?RGJ0cVhJekYwakhRRnlKbTlSekR3dVJGVHFSTkl5ZmZoL1JyTUpEQW8vRjl0?=
 =?utf-8?B?dVZCc2RDTGNkd3E3TXZ1b0Uwakh4Z1ppUkEvaGpvckdncjFuQTgxM2J4WEY1?=
 =?utf-8?B?MzdnS2xFQ0hDak9qUzZGaHBwdnB6UGU5UUVkRXZhcDdGOE5CeDh1K0t6UkZO?=
 =?utf-8?B?dlgyeFZFUUFaTzYxb3dKV3hQNDM1cE5CVm1aWVB5amYrRUE1R0x4R2h0SmN5?=
 =?utf-8?B?djNudmtPTVpBRy82NTlZbE55WGc5RWpybGwrc29hUU5NTzFKNHlyakJXaEsv?=
 =?utf-8?B?WE1RL2JRUzJGQyt4eUxIcmVLUTBJMlRTanJib1lieEZ2YlRtQWZnc3BIa3dq?=
 =?utf-8?B?QURtRllDRDZ5L1R4QkN3QVBOeUNNQS9FN2Y4cmtQN1FBVjdRQW12aVZmVUpE?=
 =?utf-8?B?SGpvdWpheWd3cE5teWY2NXdPWjlvT2l0MWIwYWg4MCt1SjJ1S1BnZ29aT3lW?=
 =?utf-8?B?OHdocUFxYVhncng3RklYanpGR3RPZGtodG5uYXVVcS9nbFFPZjhsaXYxRHdZ?=
 =?utf-8?B?MUM0VHRkMzdhVzZNMlUzTEpaR1NETkN2djJza1BSV1ltOCtLYlRzdVBuOEZE?=
 =?utf-8?B?N3EzUVJtSEZ6dWtEUU1sOXJQNVVodTJjOXdxcVMvWGFWYXBTcFF0a1I0elNl?=
 =?utf-8?B?bWpubUhEaWl5K2dzc1VIY2prbWdNeUVEblhOY3dPRFZOOXBBdXR5Tkwzajkx?=
 =?utf-8?B?SU5LWEYvU0FMU3lwQWpiRDMxQWxLV3g5SEpNdzg5Q2VmWll4ZFNqWHdpQS80?=
 =?utf-8?B?VUdHNlVrblNyYVJWbGM1OTRhWFdIQXJtSVE0RDRnQVBFVE9sbmtoYUk3WmRn?=
 =?utf-8?B?bUV0aGJrTDEzM1FhREViTUhwZXJQS0VHbUtLOFUxeTBRd1pMWVdUQzBiVUtv?=
 =?utf-8?B?eFZaV2VNNHQ5RTZac2huanVJMFF1andkd3NlQkYxU1pyd2VVa21GUE1BRmhi?=
 =?utf-8?B?TE1xRkZ5SHBkb3k4c1M3VjVabXBybmJMeWNybmY0aE1nT2VteVVxMWRsT1l4?=
 =?utf-8?B?ODVTTXRVM1FYVFZ0OXJyTjA3SVIxVXNnVkxzWEI2VmIrZW5yZFgzWXBGeVQ2?=
 =?utf-8?B?eXZZTitPNUk1VG9SRzdEanVZM0o4cmNOcGxmQWVlbDNoRWp4Y3d5Um9oSU9n?=
 =?utf-8?B?TmlzdlpHcE9ReG9NbUdPZEFtTnVSNmZ3SGV4T3Q0Zis2TE1GL1hSYWRTcmM2?=
 =?utf-8?B?cnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5497e048-9f20-4b2c-18d8-08db976cc091
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 17:35:54.7294
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CA596xZm1SuwvlrSCr3eFeWfsh3doIE8/GV6PPR0a3iYXc6f7T4VTegxaEzUTCIQ8KmtwGow4NmOWTLvYC8tNMQlA3oKxLTQ2H3g3oPkqLw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4970
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


On 8/3/2023 8:53 PM, Ruan Jinjie wrote:
> Ther are a little ternary operators, the true or false judgement
> of which is unnecessary in C language semantics.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
>  drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +-
>  drivers/net/ethernet/intel/igc/igc_phy.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c
> index a018000f7db9..c123c9dd6a49 100644
> --- a/drivers/net/ethernet/intel/igb/e1000_phy.c
> +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c
> @@ -1652,7 +1652,7 @@ s32 igb_phy_has_link(struct e1000_hw *hw, u32 iterations,
>  			udelay(usec_interval);
>  	}
>  
> -	*success = (i < iterations) ? true : false;
> +	*success = i < iterations;
>  
>  	return ret_val;
>  }
> diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c
> index 53b77c969c85..a553e9d719e7 100644
> --- a/drivers/net/ethernet/intel/igc/igc_phy.c
> +++ b/drivers/net/ethernet/intel/igc/igc_phy.c
> @@ -93,7 +93,7 @@ s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations,
>  			udelay(usec_interval);
>  	}
>  
> -	*success = (i < iterations) ? true : false;
> +	*success = i < iterations;
>  
>  	return ret_val;
>  }

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>