Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authenticated-By: 
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Yang Yingliang <yangyingliang@huawei.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
CC:     "kvalo@kernel.org" <kvalo@kernel.org>
Subject: RE: [PATCH -next] wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address
Thread-Topic: [PATCH -next] wifi: rtlwifi: use eth_broadcast_addr() to assign
 broadcast address
Thread-Index: AQHZxrKkROrQy+8xeESt6N5eKljAR6/fn/Jw
Date:   Tue, 8 Aug 2023 01:21:55 +0000
Message-ID: <79c02ca0927442419c091bcbc36cac08@realtek.com>
References: <20230804090120.1332091-1-yangyingliang@huawei.com>
In-Reply-To: <20230804090120.1332091-1-yangyingliang@huawei.com>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk


> -----Original Message-----
> From: Yang Yingliang <yangyingliang@huawei.com>
> Sent: Friday, August 4, 2023 5:01 PM
> To: linux-wireless@vger.kernel.org
> Cc: Ping-Ke Shih <pkshih@realtek.com>; kvalo@kernel.org; yangyingliang@huawei.com
> Subject: [PATCH -next] wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address
> 
> Use eth_broadcast_addr() to assign broadcast address instead
> of memcpy().
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>


> ---
>  drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
> index 4fb16f5f6f83..3835b639d453 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/core.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/core.c
> @@ -1656,7 +1656,7 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
>                         memcpy(rtlpriv->sec.key_buf[key_idx],
>                                key->key, key->keylen);
>                         rtlpriv->sec.key_len[key_idx] = key->keylen;
> -                       memcpy(mac_addr, bcast_addr, ETH_ALEN);
> +                       eth_broadcast_addr(mac_addr);
>                 } else {        /* pairwise key */
>                         rtl_dbg(rtlpriv, COMP_SEC, DBG_DMESG,
>                                 "set pairwise key\n");
> --
> 2.25.1
> 
> 
> ------Please consider the environment before printing this e-mail.