Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp4705236rwb;
        Tue, 8 Aug 2023 12:25:22 -0700 (PDT)
X-Google-Smtp-Source: AGHT+IE8IjLZmYlKpM8Bgl4Q0n4rX9ruXutG+VSPaTFqPmCB5q8OEwHejIBHJ1ZP9IVNoWzSr/i3
X-Received: by 2002:a17:906:10c:b0:99b:f53c:3648 with SMTP id 12-20020a170906010c00b0099bf53c3648mr451367eje.72.1691522722572;
        Tue, 08 Aug 2023 12:25:22 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1691522722; cv=none;
        d=google.com; s=arc-20160816;
        b=hFOcuOcn/tolmU1BwAbzYPJfalQ6qFSKB9Pk8ch4njf222WHTHPgF8jvJ+hUwCB0gl
         yWMyLx56algZO4hlMBWIglWC/1RNkNfFiyyXCfaGMVlSVQ6Cz9Nzv9FQbUfS1UThirDu
         jiOQFyONOnDoAhy9L3dJzDppynNKhFMCbbspGM8PSa3TShyrkYXYZ9swzqb239Bya1vl
         8djfGlindg64QVBIXSe3Xj6xiOCZeAywS/J9b/fN5AK4sixdrZKLBzr8fAGDZg8aYQQc
         t2TsOv7XzTNrfM6LdHoPBO2/YydMkakXxjcjzN7JOMsZrt8T0hBV5RLoXSNqWyuDt5bk
         Bv7w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent
         :content-transfer-encoding:references:in-reply-to:date:to:from
         :subject:message-id:dkim-signature;
        bh=6GDFlftfhP/GMR1eNcMBvMmcjXk4zg1377enK488Yns=;
        fh=Nx+qaFdVGJx+6ahAzWhBfPkoBhMHKQQSFyNBQ8rmP8U=;
        b=zdys5ZrOILYVL3AZGVdNJzsnOyAyzHZ6J7rdojdT5Iz64Ec17iLz4tmRkwRvRxHhWG
         2AmMQyqrn9ifPN75j8fpNlNx1QFJSRP3uhn31Mnbz1uRD5lDEPfgaOe1yKwWgTNl3JEx
         vCmRaXIYzla2m90MKxxKmWSvajBMeF7KCC98pAHI8NI5NZPVYfA6BVBpyEyQCYpJKPDv
         eKGCAmQ5dqe2xEn+fA0K31r2jNa7gpDKqVsihVoh2JyxzbZqoEA7yCBOJuYm6s/Or8PU
         2Nr949ps05XWTI/d1C+idHoG9k10C6qw9991jfU58hl4eYx3n2tmmw0bbzsA9NOGuBuk
         o65A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@sipsolutions.net header.s=mail header.b=h9VtglFb;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id kg18-20020a17090776f200b0099c93638298si7433174ejc.230.2023.08.08.12.25.08;
        Tue, 08 Aug 2023 12:25:22 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@sipsolutions.net header.s=mail header.b=h9VtglFb;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235975AbjHHTSz (ORCPT <rfc822;pigworlds@gmail.com> + 56 others);
        Tue, 8 Aug 2023 15:18:55 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48544 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S235965AbjHHTSW (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Tue, 8 Aug 2023 15:18:22 -0400
Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:242:246e::2])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D1FAFF626
        for <linux-wireless@vger.kernel.org>; Tue,  8 Aug 2023 09:41:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding:
        Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:Sender:
        Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To:
        Resent-Cc:Resent-Message-ID; bh=6GDFlftfhP/GMR1eNcMBvMmcjXk4zg1377enK488Yns=;
        t=1691512870; x=1692722470; b=h9VtglFblRlDtrldVn1GbwmG3kTSEsM83xiR0tcCC0dbWtQ
        nIGeVU3P0SbUT1C4oh5ylHX664xgWko5jYOA9Hkz8RikTdkpoDLlPGnrtYF83JW+y2er0ng3XNDFa
        tRIZrV0r+5VBdJgJwrXsQHEGwAy56b6dCXqeFgs4orlNPIUGOXzSgSGgb5cPJS1emnef2TrXxnT0C
        s6aOYltOnmGXF5AcI4Jqh1oqcl4t7PH/S1zOZ0jHYo3hHU1PyXBxXs6XgbzBZSta2ndwi46/f5mrl
        DZ89iiIo3b7fNj0uJe1DKR709oOFDTkWNbSGakoXxaGkhiLdu3VNcVqGoVz3twCQ==;
Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
        (Exim 4.96)
        (envelope-from <johannes@sipsolutions.net>)
        id 1qTI34-00CQx7-0j;
        Tue, 08 Aug 2023 10:26:38 +0200
Message-ID: <d24e41fda1a9a9742be265cd5445b4a4cb864142.camel@sipsolutions.net>
Subject: Re: [PATCH v2 1/1] wifi: changes for FILS Authentication for
 External Auth
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Kavitha Velayutham <k.velayutham@samsung.com>,
        mohit.ghuley@samsung.com, linux-wireless@vger.kernel.org
Date:   Tue, 08 Aug 2023 10:26:36 +0200
In-Reply-To: <20230728151751.1637555-1-k.velayutham@samsung.com>
References: <CGME20230728071724epcas5p32f46dd6dd091c61aaba26f28897f6378@epcas5p3.samsung.com>
         <20230728151751.1637555-1-k.velayutham@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
X-malware-bazaar: not-scanned
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Hi,

So since there's just about _everything_ wrong with this patch I'm not
even going to bother reviewing it.

Please run it by someone internal to your company who actually has
upstream development experience. Until then, please don't resubmit it
either.

johannes