Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] mac80211: mesh: Remove unused function declaration
 mesh_ids_set_default()
To:     Johannes Berg <johannes@sipsolutions.net>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <nbd@nbd.name>, <pagadala.yesu.anjaneyulu@intel.com>
CC:     <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230731140712.1204-1-yuehaibing@huawei.com>
 <cdf75cdfeb3640e7096940b3f15a8cd86bf5451e.camel@sipsolutions.net>
From:   Yue Haibing <yuehaibing@huawei.com>
Message-ID: <6c95c1e8-67f2-0da4-b853-c306f67926cc@huawei.com>
Date:   Tue, 8 Aug 2023 23:14:35 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <cdf75cdfeb3640e7096940b3f15a8cd86bf5451e.camel@sipsolutions.net>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/8/8 16:24, Johannes Berg wrote:
> On Mon, 2023-07-31 at 22:07 +0800, Yue Haibing wrote:
>> Commit ccf80ddfe492 ("mac80211: mesh function and data structures definitions")
>> introducted this but never implemented.
>>
> 
> Btw, are you detecting these with some kind of tool? Having the tool
> would probably be more useful than you sending all these patches all the
> time ...
> 
Just use grep to check like below

grep -rP --include=*.c '^(?:\w+\s+){1,3}\*{0,3}\s{0,3}\w+[\t]*\(' * |grep -P -oh '\w+\s*\('|sort| uniq -c| sort -n| grep -P '^\s+1\b'|sed -r -e 's/^\s+1\s+//' -e 's/\(//'|while read line ;
 do
        IS=`git grep -w $line |wc -l` ;
        if [ $IS -eq 1 ];then
                git grep -wn $line
        fi
done


> johannes
> .
>