Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0daa237a-43bc-e5d0-3069-dea9b4263521@quicinc.com>
Date:   Tue, 8 Aug 2023 11:41:16 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 1/2] wifi: cfg80211: Add short_beacon_tail/head/period
Content-Language: en-US
To:     Bassem Dawood <bassem@morsemicro.com>, <johannes@sipsolutions.net>,
        <linux-wireless@vger.kernel.org>
CC:     Kieran Frewen <kieran.frewen@morsemicro.com>,
        kernel test robot <lkp@intel.com>,
        Gilad Itzkovitch <gilad.itzkovitch@morsemicro.com>
References: <20230417012151.2512303-1-gilad.itzkovitch@virscient.com>
 <20230808102732.37270-1-bassem@morsemicro.com>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20230808102732.37270-1-bassem@morsemicro.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/8/2023 3:27 AM, Bassem Dawood wrote:
[snip]
> diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
> index 88eb85c63029..03df70b0238e 100644
> --- a/include/uapi/linux/nl80211.h
> +++ b/include/uapi/linux/nl80211.h
> @@ -2794,6 +2794,12 @@ enum nl80211_commands {
>    *	indicates that the sub-channel is punctured. Higher 16 bits are
>    *	reserved.
>    *
> + * @NL80211_ATTR_SHORT_BEACON_PERIOD: (u16) period for S1G long beacon
> + * @NL80211_ATTR_SHORT_BEACON_HEAD: portion of the S1G short beacon before
> + *  the TIM element
> + * @NL80211_ATTR_SHORT_BEACON_TAIL: portion of the S1G short beacon after
> + *  the TIM element
> + *
>    * @NL80211_ATTR_MAX_HW_TIMESTAMP_PEERS: Maximum number of peers that HW
>    *	timestamping can be enabled for concurrently (u16), a wiphy attribute.
>    *	A value of 0xffff indicates setting for all peers (i.e. not specifying
> @@ -3346,6 +3352,10 @@ enum nl80211_attrs {
>   
>   	NL80211_ATTR_PUNCT_BITMAP,
>   
> +	NL80211_ATTR_SHORT_BEACON_PERIOD,
> +	NL80211_ATTR_SHORT_BEACON_HEAD,
> +	NL80211_ATTR_SHORT_BEACON_TAIL,
> +

This is a UAPI so all additions must go at the end to avoid renumbering 
the values of existing enumerations

>   	NL80211_ATTR_MAX_HW_TIMESTAMP_PEERS,
>   	NL80211_ATTR_HW_TIMESTAMP_ENABLED,