Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4b53807c-cbe6-dbd6-0ff6-b0342abe7198@quicinc.com>
Date:   Wed, 9 Aug 2023 11:35:28 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.14.0
Subject: Re: [PATCH] wifi: ath12k: Fix buffer overflow when scanning with
 extraie
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>,
        <ath12k@lists.infradead.org>
CC:     <linux-wireless@vger.kernel.org>
References: <20230807030806.9345-1-quic_wgong@quicinc.com>
 <6ccf4549011f0efa67523d1c171b23694122ec6c.camel@sipsolutions.net>
From:   Wen Gong <quic_wgong@quicinc.com>
In-Reply-To: <6ccf4549011f0efa67523d1c171b23694122ec6c.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/8/2023 6:55 PM, Johannes Berg wrote:
> Hi,
>
> Since I'm covering for Kalle right now ...
>
> On Sun, 2023-08-06 at 23:08 -0400, Wen Gong wrote:
[...]
> I feel these are two separate issues. Having a large enough TLV that the
> firmware cannot parse it is highly unlikely to happen, and not really an
> issue here.
>
> Please split this into two patches, and fix *just* the buffer overflow
> in a patch titled "Fix buffer overflow". I believe simply changing the
> variable type is sufficient for this, as the code is otherwise
> equivalent. That's a patch I'd take to wireless at this stage (rc5), but
> probably not the entire bigger change.
>
> johannes
Yes, let me send the 2 patch separately .