Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e78119dc1ae2e22ea84b6528492aeba1ab6bfcec.camel@sipsolutions.net>
Subject: Re: [PATCH v2] wifi: mwifiex: added code to support host mlme.
From:   Johannes Berg <johannes@sipsolutions.net>
To:     David Lin <yu-hao.lin@nxp.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc:     Sharvari Harisangam <sharvari.harisangam@nxp.com>,
        Pete Hsieh <tsung-hsien.hsieh@nxp.com>
Date:   Wed, 09 Aug 2023 14:23:24 +0200
In-Reply-To: <PA4PR04MB9638FE710460BC44BA290470D112A@PA4PR04MB9638.eurprd04.prod.outlook.com>
References: <PA4PR04MB9638FE710460BC44BA290470D112A@PA4PR04MB9638.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

Please see

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes#commit_messages

> 3. The code is enabled and tested with IW416.
>    There is no guarantee for other chips.

That seems misleading - it's not even enabled for other chips, is it?

Or are you saying that there are multiple variants of sd8979, and only
one of them is supported?! In that case you need to detect it.

Also, it seems like you likely need to detect the firmware version that
has the support, not just the hardware?


> +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
> @@ -331,6 +331,7 @@ static const struct mwifiex_sdio_device mwifiex_sdio_=
sd8786 =3D {
>  	.can_dump_fw =3D false,
>  	.can_auto_tdls =3D false,
>  	.can_ext_scan =3D false,
> +	.host_mlme =3D false,

probably better to not have all the =3Dfalse lines that are default
anyway?

This is the only one enabling it afaict:

>  static const struct mwifiex_sdio_device mwifiex_sdio_sd8978 =3D {
> @@ -408,6 +413,7 @@ static const struct mwifiex_sdio_device mwifiex_sdio_=
sd8978 =3D {
>  	.fw_dump_enh =3D true,
>  	.can_auto_tdls =3D false,
>  	.can_ext_scan =3D true,
> +	.host_mlme =3D true,
>  };

johannes