Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     kvalo@kernel.org, Li Zetao <lizetao1@huawei.com>
Cc:     lizetao1@huawei.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH -next] wifi: wfx: Use devm_kmemdup to replace devm_kmalloc +
 memcpy
Date:   Thu, 10 Aug 2023 14:44:19 +0200
Message-ID: <2435182.NgBsaNRSFp@pc-42>
Organization: Silicon Labs
In-Reply-To: <20230810114939.2104013-1-lizetao1@huawei.com>
References: <20230810114939.2104013-1-lizetao1@huawei.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?1tBGS7fhT50zxCgSYz6Uh/AYvDqQf/LUwKJDEkiUuRPHQgvXNCJE0gYndp?=
 =?iso-8859-1?Q?EGArua7Y6SATe9LtS2djFscO2tt7Gi7A5bwSWj8ILyLht+cHFKPDciaUmD?=
 =?iso-8859-1?Q?z58oWeauSMm+MQzjceXFcjtgk2Amghc5f0b3801dgSI/Qt2axTBbgX/ZLT?=
 =?iso-8859-1?Q?57dwD97MygvrSqyasGeBLtQKefpxhfz73bTdTSCtxVdui/R8/lSrbTM3v3?=
 =?iso-8859-1?Q?a550IFibcRgZoeA1/O42Df3fzOwK1VmKCen40kw4RtWSS+JNi20cfibpHi?=
 =?iso-8859-1?Q?4YXldagGdBj2PWVzATCfLaHuh85uR8QeTMWJ/0AmAK6Vm/m6eQQPU6L6rI?=
 =?iso-8859-1?Q?OCUGm9uBcrdLwavUcEEGWEV+Jq+NEliIT8k8Q8NBn02mFmp7YKtn0utElm?=
 =?iso-8859-1?Q?mJ+Es7yedZBx67+O61baFCSFilIoNw8vM1a7sVzzQSXy8PY/81C0gk3GIa?=
 =?iso-8859-1?Q?q0weDNXAxZ632jAw8WUJdegWedl1zSA6LWwQkxHh44bHS5k5HGUTd4vOrZ?=
 =?iso-8859-1?Q?xuErdyNLshO0dRJqj05ROWeArYRI/Bi2CQZoyJ9aRoSDYt5992MyrDEwlK?=
 =?iso-8859-1?Q?qZpiBvDeCkHkm8VvSW06u9h44naLIqblCeklhx0tvz7LECm//Aqil1qT+8?=
 =?iso-8859-1?Q?kElm89zrcMkIa4SL/fVortXQAKxp9t1K+JL4oN0kbyFe/XRUtQj7g4tk4v?=
 =?iso-8859-1?Q?EfWKoisX+nQYUIgrh1mg0SUKCwgSuwBV+5IOnyZQqe6pJWuf6XE5KD+8MF?=
 =?iso-8859-1?Q?Hn3jFo++yDxFdhWHJZfF461/sBTacNNg/YpHFamOrMhMrE2YvUnyDhKamb?=
 =?iso-8859-1?Q?DNNeilXh6lhdjC9YEnRh9DL6HkUJQQ3eBn9XQ04o+wYfqJQPTRU+ChfmuP?=
 =?iso-8859-1?Q?I5i6eWxE4/wkromiackALTJCi67iZMYKMZFDOaQO32+ZAu+nOmBf168O+C?=
 =?iso-8859-1?Q?PrZI2ZOxg+k6rB4zsKkAy5dTe0u2WqcTB+lytucZ3bZsjp+XhVbjJHzj1g?=
 =?iso-8859-1?Q?/7CuFMCsidmP7Tom/PSL4qGQw6d5FRrdvNzYynkNiPCGSL9wLZbS1z0r+c?=
 =?iso-8859-1?Q?RlJv5HftYboMBoL60KrE8S8Fub3Ul2unuW0/mApQoiQIUOo7wPVpG/ELmr?=
 =?iso-8859-1?Q?oEOKbt1Qa42B2fS/qwpt5WE+4Dlkb+8PiwMr5lSP1I+FxzWJedhEDHC1iX?=
 =?iso-8859-1?Q?vtFCGnz9yjm3DE6uOhzA1dJ8i46nykxUTzzWMTMNsKQLkLZYTy2sisZEtv?=
 =?iso-8859-1?Q?mxQ3Qzs/SMzOpvxjAqNsqaHpb1ih1JXF3oZGZdGT5fNfEecsdj+8qU4gfC?=
 =?iso-8859-1?Q?sjyHoI+ySMxr3HjCUujpmb324azeiSMNiGEyUcmuoBPMK2Ro8O09fYdjbT?=
 =?iso-8859-1?Q?t3cvflR0RKmidrZgu14abVNKwrMK3ox6d3Kmig5LVxML4v/Kg80y22ROTq?=
 =?iso-8859-1?Q?PW7CFTEAE+9Jta+VMTUJtXjAW1feOrrl9uI9vxtEEIEy8zscPtb6+W9aeT?=
 =?iso-8859-1?Q?h4gAujEUvP4QvJADOIInN18AzKpmF/8G9I9nwjNWIp0m7zWF7ezh3lIIC8?=
 =?iso-8859-1?Q?7lUWgc1aJX8v4pt1BNS1gUxQj0RGxGQS7jFba8cB8/JpklBgbesjAVUCYJ?=
 =?iso-8859-1?Q?WEEDjzWNCzluwZKgjdOTu6TlZeKqX/jUTk?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22ab89d5-680f-45c2-3603-08db999f86b3
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7773.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 12:44:24.3215
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1NfxVxRT6P47eem2Zkkr296WWzLXSPdoB8WjJMJU2ENKhdiR9CS6+Gt5Ck1EfS7Wl0htn4rKuK2TalR936PdMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4983
X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,FORGED_SPF_HELO,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Thursday 10 August 2023 13:49:39 CEST Li Zetao wrote:
> Use the helper function devm_kmemdup() rather than duplicating its
> implementation, which helps to enhance code readability.
>=20
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
> ---
>  drivers/net/wireless/silabs/wfx/main.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/net/wireless/silabs/wfx/main.c b/drivers/net/wireles=
s/silabs/wfx/main.c
> index 0b50f7058bbb..ede822d771aa 100644
> --- a/drivers/net/wireless/silabs/wfx/main.c
> +++ b/drivers/net/wireless/silabs/wfx/main.c
> @@ -293,13 +293,12 @@ struct wfx_dev *wfx_init_common(struct device *dev,=
 const struct wfx_platform_da
>         hw->wiphy->max_scan_ie_len =3D IEEE80211_MAX_DATA_LEN;
>         hw->wiphy->n_iface_combinations =3D ARRAY_SIZE(wfx_iface_combinat=
ions);
>         hw->wiphy->iface_combinations =3D wfx_iface_combinations;
> -       hw->wiphy->bands[NL80211_BAND_2GHZ] =3D devm_kmalloc(dev, sizeof(=
wfx_band_2ghz), GFP_KERNEL);
> +       /* FIXME: also copy wfx_rates and wfx_2ghz_chantable */
> +       hw->wiphy->bands[NL80211_BAND_2GHZ] =3D devm_kmemdup(dev, &wfx_ba=
nd_2ghz,
> +                                                          sizeof(wfx_ban=
d_2ghz), GFP_KERNEL);
>         if (!hw->wiphy->bands[NL80211_BAND_2GHZ])
>                 goto err;
>=20
> -       /* FIXME: also copy wfx_rates and wfx_2ghz_chantable */
> -       memcpy(hw->wiphy->bands[NL80211_BAND_2GHZ], &wfx_band_2ghz, sizeo=
f(wfx_band_2ghz));
> -
>         wdev =3D hw->priv;
>         wdev->hw =3D hw;
>         wdev->dev =3D dev;
> --
> 2.34.1
>=20
>=20

Make sense.

Reviewed-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>

--=20
J=E9r=F4me Pouiller